mirrors/arti.git/crates/tor-proto/src, branch arti-v0.0.4 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.4 2022-01-26T19:06:58Z Remove a now-incorrect comment in tor-proto. 2022-01-26T19:06:58Z Nick Mathewson nickm@torproject.org 2022-01-26T19:06:48Z urn:sha1:884d614a618564d8a80ecb630256e7458c8943f8 clippy: Rename a `decode_chanmsg` from `handle_` 2022-01-19T18:46:13Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T18:45:20Z urn:sha1:9a77b23cddee1ed378ac0af8c2b248c3880bc069 As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771025 It doens't really handle it. handshake: Use read_exact, not read and checking len 2022-01-19T18:45:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T18:38:00Z urn:sha1:6c5e099be99fc7e756244f72486e92adb8b5d3ac read_exact has a loop in it, which we need. This means we end up separating the two sites that generate the "not a relay" error, so we need to fish out the error construction. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771023 clippy: Rename a `from_foo` method that doesn't do conversion 2022-01-19T17:26:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T17:20:35Z urn:sha1:c4338999488cd332544c6d91cee6b42a36ebe569 Fix two bugs related to incomplete read/write 2022-01-19T17:17:56Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T17:17:56Z urn:sha1:1d5a480f79e7d878ff291e6e8fc5225e17328919 Discovered by clippy Merge branch 'channel-arc-rework-5' into 'main' 2022-01-13T13:12:30Z eta tor@eta.st 2022-01-13T13:12:30Z urn:sha1:c003fde04dc1d3920a5e0c2426bc4c786463bc36 chanmgr: get rid of Arc around Channel See merge request tpo/core/arti!236 chanmgr: get rid of Arc around Channel 2022-01-13T13:12:29Z Ian Jackson iwj@torproject.org 2022-01-13T13:12:29Z urn:sha1:9b723cba53852ecd3505c0cabc42ca3b5d31ad34 Describe when we will need SendmeAcceptMinVersion 2022-01-12T20:52:24Z Nick Mathewson nickm@torproject.org 2022-01-12T20:52:24Z urn:sha1:bbf7c59b2dc7ed8aeaf3604beeb619961874610c (spoiler: not until we have a relay implementation) Closes #53. Change RequireSendmeAuth to an enum. 2022-01-12T20:46:36Z Nick Mathewson nickm@torproject.org 2022-01-12T20:46:36Z urn:sha1:e335f6c75aca2a39244390bd5f3c8ca66b2071d4 This is a fine example of why booleans are risky: it's far to easy to pass "animate:bool" into "inanimate:bool" like we did here. This is a followup from our fix to #294. Fix a boolean inversion in auth_sendme_optional. 2022-01-12T20:36:55Z Nick Mathewson nickm@torproject.org 2022-01-12T20:32:16Z urn:sha1:1e915c39465d616d71e57331d89e02235f156a31 Previously we were requiring authenticated sendme cells exactly when we should be permitting the old format, and vice versa. This bug was caused by using a boolean to represent one property, but with giving that boolean two different senses without inverting at the right time. The next commit will prevent a recurrence. Closes #294