mirrors/arti.git/crates/tor-proto/src/util, branch arti-v1.7.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.7.02025-10-08T19:58:47Ztor-proto: bring back comparison chain w/ allow2025-10-08T19:58:47ZhashcatHitman3924-hashcatHitman@gitlab.torproject.org2025-10-08T19:58:47Zurn:sha1:54a99b218864c420d3dd39ca45a6e244f24c8bcf
It was decided that the comparison chain was actually preferrable for
readability. So instead, we're just `allow`ing it until it stops being
a problem.
Signed-off-by: hashcatHitman <3924-hashcatHitman@gitlab.torproject.org>
tor-proto: replace comparison chain with match2025-10-08T13:13:40ZhashcatHitman3924-hashcatHitman@gitlab.torproject.org2025-10-08T12:48:15Zurn:sha1:783126f8cd71b94eb5b0f9749a7c937976de6705
There was a comparison chain in
`tor_proto::util::poll_all::test::ResolveAfter::poll` which was causing
a clippy warning. The lint in question, `clippy::comparison_chain`, was
a `clippy::style` lint in 1.85.1 and got moved to `clippy::pedantic` in
1.87.0 (see [rust-clippy!14219]).
Since some of us (like me) develop on MSRV, I'm fixing this lint now.
Gabi didn't have any strong opinions on whether I did it like this or
with an `allow` attribute, so I decided this was better since it means
we don't have to come back later just to remove the `allow`.
It should be noted that using a match like this can sometimes be a
performance regression (see [rust-clippy#5354] and [rust-clippy!6390]).
I would expect in this case the effect will be very little, if any, but
if tests in `tor_proto::util::poll_all::test` start taking much longer
and having an impact on CI or something, this could be why.
[rust-clippy!14219]: https://github.com/rust-lang/rust-clippy/pull/14219
[rust-clippy#5354]: https://github.com/rust-lang/rust-clippy/issues/5354
[rust-clippy!6390]: https://github.com/rust-lang/rust-clippy/pull/6390
Signed-off-by: hashcatHitman <3924-hashcatHitman@gitlab.torproject.org>
proto: Implement channel padding with maybenot padders.2025-10-02T16:04:40ZNick Mathewsonnickm@torproject.org2025-10-02T14:09:15Zurn:sha1:9a6d37141a09bc24581d0a872ef53f141595a042
With this commit we now actually generate padding when we're told to.
proto: start implementing logic for padding actions.2025-10-02T16:04:40ZNick Mathewsonnickm@torproject.org2025-10-01T20:14:37Zurn:sha1:7d220263a5dc8ac4798d7ce5cc3eae1109b9df5cAdd a blocker to channel outbound sink.2025-10-02T16:04:40ZNick Mathewsonnickm@torproject.org2025-10-01T19:13:16Zurn:sha1:36864325e82b296c51efbce65467ab2b483a7196padding: Remove post-queue blocker.2025-09-30T14:32:14ZNick Mathewsonnickm@torproject.org2025-09-29T15:52:03Zurn:sha1:4c6e8698283a393ed5880d8e57c069a11a87e953
We no longer want to _ever_ block non-DATA cells, per discussion
in circuit-padding.md.
Closes #2190.
proto: Document exactly how PollAll polls its futures.2025-09-25T13:40:33ZGabriela Moldovangabi@torproject.org2025-09-23T14:22:00Zurn:sha1:b5741ec67468b1efbaaef848e13e950599887ab7proto: Resolve a couple of clippy warnings in the tests.2025-09-25T13:40:33ZGabriela Moldovangabi@torproject.org2025-09-22T17:07:09Zurn:sha1:326b808ea141faffcc72f556bd0c10740ca31e6dproto: Add PollAll helper for driving futures in lockstep.2025-09-25T13:37:41ZGabriela Moldovangabi@torproject.org2025-09-18T16:58:14Zurn:sha1:563e8965f9df29735b010eac9a7588fbf0941789Merge branch 'expire-halfstream-cbt' into 'main'2025-09-24T18:08:19Zgabi-250gabi@torproject.org2025-09-24T18:08:19Zurn:sha1:276b8a5820f55eb2f0e09f424e22f794b111fcf1
proto: Remove half-streams when they expire.
Closes #264
See merge request tpo/core/arti!3267