mirrors/arti.git/crates/tor-proto/src/util, branch arti-v1.1.5

Allow clippy::unchecked_duration_subtraction in tests

2023-01-27T13:28:02Z

This panics on error, and we're fine with a panic on misbehavior in tests.

test lint blocks: Add many many automatically

2022-12-12T18:00:30Z

This is precisely the result of running the rune in maint/adhoc-add-lint-blocks.

Final (?) API revisions for tor-linkspec

2022-08-10T14:39:37Z

With this change, each individual identity type becomes optional. The functions that expose them unconditionally are now in a "legacy" trait that only some downstream types are expected to implement. There are new convenience APIs in HasRelayIds: * to return Option<&keytype>, * to see if one identity-set contains another. This commit will break several downstream crates! For the reviewer's convenience, I will put the fixes for those crates into a series of squash! commits on this one. tor-netdir ---------- Revise tor-netdir to accept optional identities. This required some caveats and workarounds about the cases where we have to deal with a key type that the tor-netdir code does not currently recognize at all. If we start to add more identity types in the future, we may well want more internal indices in this code. tor-proto --------- In order to make tor-proto support optional identities, there were fewer changes than I thought. Some "check" functions needed to start looking at "all the ids we want" rather than at "the two known IDs"; they also needed to accommodate that case where we don't have an ID that we demand. This change will also help with bridges, since we want to be able to connect to a bridge without knowing all of its IDs up front. The protocol currently _requires_ the two current ID types in some places. To deal with that, I added a new `MissingId` error. I also removed a couple of unconditional identity accessors for chanmgr; code should use `target().identity(...)` instead. tor-chanmgr ----------- This is an incomplete conversion: it does not at all handle channel targets without Ed25519 identities yet. It still uses those identities to index its internal map from identity to channel; but it gives a new `MissingId` error type if it's given a channel target that doesn't have one. We'll want to revise the map type again down the road when we implement bridges, but I'd rather not step on the channel-padding work in progress right now. tor-guardmgr ------------ This change is mostly a matter of constructing owned identity types more sensibly, rather than unwrapping them directly. There are some places marked with TODOs where we still depend on particular identity types, because of how the directory protocol works. This will need revisiting when we add bridge support here. tor-circmgr ----------- These changes are just relatively simple API changes in the tests.

tor-proto: Stop using write_infallible in handshake code.

2022-07-11T15:18:51Z

This change was a bit annoying, since most of this code _can't_ fail, and so the only reasonable response is to wrap the input in an internal error... except for one case where we're actually encoding a caller-provided message, so we _do_ want to wrap the EncodeError from tor_bytes.

tor-proto: split and elaborate tor_bytes::Error instances

2022-06-23T19:42:45Z

Some of these were for decoding particular objects (we now say what kind of objects), and some were unrelated tor_cert errors that for some reason we had shoved into a tor_bytes::Error. There is now a separate tor_cert::CertError type, independent from tor_cert's use of `tor_bytes::Error` for parsing errors.

tor-proto: Split CellErr based on activity.

2022-06-23T18:59:52Z

Failing to encode is fundamentally different from failing to decode. We now treat those separately, and describe _what_ we failed to encode or decode.

tor-proto: clean up error names and messages

2022-06-23T18:35:26Z

This avoids adding additional information for now; that will come on the next commits.

Merge branch 'display_source_cleanup' into 'main'

2022-06-21T19:34:27Z

Do not include error source() in display() format. See merge request tpo/core/arti!598

tor-proto: err: Provide ChannelClosed as a separate unit error

2022-06-21T18:19:28Z

Do not include error source() in display() format.

2022-06-21T18:14:14Z

According to doc/Errors.md, and in keeping with current best practices, we should not include display an error's `source()` as part of that error's display method. Instead, we should let the caller decide to call source() and display that error in turn. Part of #323.