mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.6.0 2022-07-11T15:18:51Z 2022-07-11T15:18:51Z Nick Mathewson nickm@torproject.org 2022-07-11T15:04:27Z urn:sha1:fbb6484025ac024642afbeef6734d88e35210673 This change was a bit annoying, since most of this code _can't_ fail, and so the only reasonable response is to wrap the input in an internal error... except for one case where we're actually encoding a caller-provided message, so we _do_ want to wrap the EncodeError from tor_bytes. 2022-06-23T19:42:45Z Nick Mathewson nickm@torproject.org 2022-06-23T19:42:45Z urn:sha1:38004a4f4dd3aa99b81b6585039e81dc77c17f32 Some of these were for decoding particular objects (we now say what kind of objects), and some were unrelated tor_cert errors that for some reason we had shoved into a tor_bytes::Error. There is now a separate tor_cert::CertError type, independent from tor_cert's use of `tor_bytes::Error` for parsing errors. 2022-06-23T18:59:52Z Nick Mathewson nickm@torproject.org 2022-06-23T18:59:52Z urn:sha1:35b7b8a47ad96f5eee032fab7900b3b29bf2fa73 Failing to encode is fundamentally different from failing to decode. We now treat those separately, and describe _what_ we failed to encode or decode. 2022-06-23T18:35:26Z Nick Mathewson nickm@torproject.org 2022-06-23T18:35:26Z urn:sha1:92fd9fb0dec25ddd45a4428603db99bad8d72661 This avoids adding additional information for now; that will come on the next commits. 2022-06-21T19:34:27Z eta tor@eta.st 2022-06-21T19:34:27Z urn:sha1:4e3537746f4aa5d4df4abd5cb2be1385a4baa64b Do not include error source() in display() format. See merge request tpo/core/arti!598 2022-06-21T18:19:28Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-16T17:16:31Z urn:sha1:13ca24ba3ae5a17744355b26a1706bd5aaa07891 2022-06-21T18:14:14Z Nick Mathewson nickm@torproject.org 2022-06-21T18:14:14Z urn:sha1:08d9bbf33b9fff8aa33a823422aa4e323137be07 According to doc/Errors.md, and in keeping with current best practices, we should not include display an error's `source()` as part of that error's display method. Instead, we should let the caller decide to call source() and display that error in turn. Part of #323. 2022-06-08T15:02:22Z Ian Jackson iwj@torproject.org 2022-06-08T15:00:49Z urn:sha1:af92d72b3910a4f5a0b214bde38d6488caa8ce22 2022-06-08T15:02:01Z trinity-1686a trinity@deuxfleurs.fr 2022-06-02T17:43:47Z urn:sha1:6c6998a65b815ffe5c20b5c1db48d76af55648e9 2022-06-02T18:56:42Z Nick Mathewson nickm@torproject.org 2022-06-02T17:31:43Z urn:sha1:967ea67b7dfc158f29cf449eb09bac89acdee46b This only affects uses of thread_rng(), and affects them all more or less indiscriminately. One test does not work with ARTI_TEST_PRNG=deterministic; the next commit will fix it.