mirrors/arti.git/crates/tor-proto/src/util/poll_all.rs, branch main

maint: Run maint/add_warning to deny string slices

2026-06-09T15:36:01Z

This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit.

proto: Remove an allow for a now-pedantic warning.

2026-05-07T12:08:01Z

Fix name of clippy lint to unchecked_time_subtraction (2)

2025-11-06T11:28:22Z

Run maint/add_warning

tor-proto: bring back comparison chain w/ allow

2025-10-08T19:58:47Z

It was decided that the comparison chain was actually preferrable for readability. So instead, we're just `allow`ing it until it stops being a problem. Signed-off-by: hashcatHitman <3924-hashcatHitman@gitlab.torproject.org>

tor-proto: replace comparison chain with match

2025-10-08T13:13:40Z

There was a comparison chain in `tor_proto::util::poll_all::test::ResolveAfter::poll` which was causing a clippy warning. The lint in question, `clippy::comparison_chain`, was a `clippy::style` lint in 1.85.1 and got moved to `clippy::pedantic` in 1.87.0 (see [rust-clippy!14219]). Since some of us (like me) develop on MSRV, I'm fixing this lint now. Gabi didn't have any strong opinions on whether I did it like this or with an `allow` attribute, so I decided this was better since it means we don't have to come back later just to remove the `allow`. It should be noted that using a match like this can sometimes be a performance regression (see [rust-clippy#5354] and [rust-clippy!6390]). I would expect in this case the effect will be very little, if any, but if tests in `tor_proto::util::poll_all::test` start taking much longer and having an impact on CI or something, this could be why. [rust-clippy!14219]: https://github.com/rust-lang/rust-clippy/pull/14219 [rust-clippy#5354]: https://github.com/rust-lang/rust-clippy/issues/5354 [rust-clippy!6390]: https://github.com/rust-lang/rust-clippy/pull/6390 Signed-off-by: hashcatHitman <3924-hashcatHitman@gitlab.torproject.org>

proto: Document exactly how PollAll polls its futures.

2025-09-25T13:40:33Z

proto: Resolve a couple of clippy warnings in the tests.

2025-09-25T13:40:33Z

proto: Add PollAll helper for driving futures in lockstep.

2025-09-25T13:37:41Z