mirrors/arti.git/crates/tor-proto/src/tunnel/reactor.rs, branch arti-v1.4.4

tor-proto: Replace TOOD(conflux) with TODO(#1999).

2025-05-28T11:03:27Z

We can tackle this later, after we finish addressing all the remaining `TODO(conflux)`.

tor-proto: Remove multi-path check from allow_stream_requests().

2025-05-20T14:30:25Z

Previously, `ClientCirc:allow_stream_requests()` would return an error when called on a multi-path tunnel. My main reason for removing the conflux set length check is because it enables us to remove the `QueryLegs` control command (which is something we were planning on doing anyway). Note that now that we've removed `ClientCirc::legs(), there's no way for a multi-path `ClientCirc` to access its circuit legs, but that is fine, because it's currently impossible to build multi-path `ClientCirc`s in arti anyway. This issue will be addressed in the fork, in the new `ClientTunnel` type that will be used for multi-path tunnels (a `ClientCirc` will only ever be single-path, so it won't need to have a `legs()` function at all). I am also removing the `TODO(conflux)` that justifies the now-removed check, because it's outdated (nowadays the `CellHandlers` are shared between the tunnel reactor and its circuits). That said, we *still* don't support onion service conflux, but that will be tackled separately because there are a bunch of issues that still need to be resolved to make it work (which I'll document separately). Note that I've also made some changes to pass the `LegId` of the circuit that received the incoming stream request to `StreamReqInfo` and `StreamTarget`. This is in preparation for supporting multipath onion service conflux, and because the `HopLocation` from `StreamTarget` *needs* a `LegId`.

proto: temporarily suppress warning; see #2003.

2025-05-16T01:38:25Z

tor-proto: Add TODO about possibly replacing LegIdKey with UniqId.

2025-05-15T16:33:33Z

tor-proto: Rework MutableState to work with multi-path circuits.

2025-05-15T16:33:33Z

We now have a new `TunnelSharedState` type for storing the shared state of a tunnel. It consists of the `MutableState`s of all the circuits in the tunnel, which are shared between it and `Circuit` (the circuit subcomponent of the reactor). The `TunnelSharedState` itself is shared between `ConfluxSet` (which manages the `Circuits`), and `ClientCirc` (the reactor handle used to access information about circuits, such as their `Path`).

tor-proto: Add From impl for LegId.

2025-05-15T16:33:33Z

This will simplify some callsites.

tor-proto: Encapsulate MutableState operations inside impl.

2025-05-15T16:33:33Z

Not locking the `MutableState` mutex outside of this impl makes it easier to see it's currently impossible deadlock.

tor-proto: Rename MutableState to CircuitState.

2025-05-15T16:33:29Z

This renaming is in preparation for the addition of a newtype wrapper for what used to be `Mutex`. That newtype wrapper will be called `MutableState`.

tor-proto: Document why RemoveLegReason exists.

2025-05-06T12:12:14Z

tor-proto: Move error binding under is_conflux_pending condition.

2025-05-06T12:12:14Z

We don't use it outside this branch, so might as well move it there.