mirrors/arti.git/crates/tor-proto/src/tunnel.rs, branch arti-v1.4.5

tor-proto: improve documentation for `StreamTarget::send_sendme`

2025-06-26T17:26:49Z

Make `StreamTarget::send_sendme` non-async

2025-06-26T17:03:08Z

There are some pros/cons to this change: Pros: 1. The only remaining `await` in `StreamReceiver::recv` is for polling the receiver, which means we can turn the `StreamReceiver` into a `Stream` in a future commit. 2. We won't block the user from receiving messages while we wait for the circuit reactor to receive our SENDME message and send it on the outgoing channel. 3. The `StreamReceiver` doesn't really care if it can't send the SENDME. There isn't anything it can do, the circuit hop can go away for external reasons like a DESTROY message, and we still want to return all queued messages to the user anyways. Cons: 1. If the `StreamReceiver` sends a SENDME request to the circuit reactor, and the circuit reactor fails to send the SENDME, there's no good way for the reactor to communicate this back to the `StreamReceiver`.

hsservice: Stop using HopNum and use TargetHop

2025-06-26T14:18:30Z

This requires some changes to the tor-proto crate to handle the inbound TargetHop from the HS subsystem and then resolve it into a HopNum for a single circuit. It is expected that this will change again with Conflux to only use HopLocation internally in a Tunnel and then use HopNum into a Circuit. Signed-off-by: David Goulet

hs: Remove the use of HopNum and instead use TargetHop

2025-06-26T14:18:30Z

This is in the spirit of making everything going inbound the tor-proto crate to use a TargetHop. This becomes much easier for the HS subsystem as it only uses the last hop for its conversation and setup. Signed-off-by: David Goulet

proto: Add From<(UniqId, HopNum)> for TargetHop

2025-06-26T14:18:30Z

Quick helper as within the tor-proto crate, we sometimes have to quickly get a TargetHop. This will come handy with the message handler used by the Conversation object that the HS subsystem uses. Signed-off-by: David Goulet

proto: Make TargetHop and HopLocation public

2025-06-26T14:18:30Z

This is about to be used outside of tor-proto. It is part of the work to remove the use of HopNum outside tor-proto. The rules are: - Inbound requsest to the tor-proto crate, TargetHop must always be used. - Within tor-proto, TargetHop is resolved into a HopLocation which is more precise and based on the tunnel circuit(s). This is another piece that Conflux will require considering that a Tunnel might have multiple circuits in the future. Signed-off-by: David Goulet

tor-proto: Replace LegId/LegIdKey with UniqId.

2025-06-13T16:13:45Z

Closes #1999

tor-proto: Add an identifier for a circuit within a tunnel.

2025-06-12T18:02:30Z

This type will help produce better logs (logging just the circuit ID would make it impossible to correlate said circuit with the tunnel it belongs to).

tor-proto: Add a new identifier type for tunnels.

2025-06-12T18:02:30Z

Currently, a tunnel is uniquely identified by the `UniqId` of the first circuit added to the tunnel. This works, but the double-meaning of the `UniqId` is bound to cause confusion in the future (because it blurs the distinction between tunnels and circuits). This introduces a new `TunnelId` type which will replace `UniqId` in the tunnel reactor.

cell, proto: Use correct Data sizes for v1 relay cells

2025-04-16T14:58:49Z

Since v1 cells have a longer tag, they can fit less data into a single cell. Ah well, that's the cost of improved security. The code in data.rs is a little wonky, in that it currently requires its buffer to be exactly the maximum size for a data cell. We have a TODO about fixing that in the future, but for now I've moved it to use a boxed slice rather than a boxed array. Part of #1944.