mirrors/arti.git/crates/tor-proto/src/stream, branch derive-traitsmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=derive-traits2022-02-25T12:23:49Ztor-proto datastream: Fix typo in Debug impl2022-02-25T12:23:49ZIan Jacksonijackson@chiark.greenend.org.uk2022-02-25T10:55:50Zurn:sha1:3903900461d3558ac8f5255ba7c77c006a3c82cf
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/353#note_2781632
Fix rustfmt2022-02-24T19:45:58ZIan Jacksonijackson@chiark.greenend.org.uk2022-02-24T19:45:58Zurn:sha1:78ab634ed9ceffaef810f343c1e21706041acad1tor-proto datastream: Do not dump packet data in DataWriterImpl2022-02-24T19:39:18ZIan Jacksonijackson@chiark.greenend.org.uk2022-02-24T18:56:07Zurn:sha1:f3520478b1c757f291532bca72aca42a471d2e07tor-proto datastream: import std::fmt::Debug trait name2022-02-24T19:39:18ZIan Jacksonijackson@chiark.greenend.org.uk2022-02-24T18:55:32Zurn:sha1:097c852e58d422d7a4a6dd31303a15f6dac321feimpl Debug for DataStream (and its components)2022-02-24T17:49:34ZIan Jacksonijackson@chiark.greenend.org.uk2022-02-24T17:47:42Zurn:sha1:b56115a04fb0ebedae04a5302a04501b83b845a6
My proximate motivation is that tls-api wants its inner streams to be
Debug. But in general, I agree with the Rust API Guidelines notion
that almost everything should be Debug.
I have gone for the "dump all the things" approach. A more nuanced
approach would be possible too.
Update tor-proto errors to latest API.2022-02-15T14:57:03ZNick Mathewsonnickm@torproject.org2022-02-15T14:57:03Zurn:sha1:6b611d6deae2e003ea81f459cd5e005c37ab50ceMake tor-proto::Error implement HasKind.2022-02-15T14:41:47ZNick Mathewsonnickm@torproject.org2022-02-11T21:27:27Zurn:sha1:4af279b1730a058093b250696beddd0228793b6d
This took some refactoring, and gave an opportunity to notice
a few error variants that weren't being used, or didn't mean
what they said on the tin.
tor-proto: use InternalError for internal errors.2022-02-15T14:41:11ZNick Mathewsonnickm@torproject.org2022-02-11T20:20:50Zurn:sha1:f23f375e42ef3237f9bbb7b8bfee47ecc9ced4a1Add a blank line between doc and comment.2022-01-11T18:23:58ZIan Jacksoniwj@torproject.org2022-01-11T18:23:58Zurn:sha1:cfcd3ea6891d53f3c8eaa12dcbec06e664c3973bImprove the layout of crate exports; add runtime convenience functions2022-01-11T15:16:03Zetator@eta.st2022-01-11T15:16:03Zurn:sha1:41e202a3a4c582dedd2c9c5c5c60369b4a53fae0
This commit addresses multiple problems highlighted by arti#182:
- `arti-client` had some types in its public API that weren't accessible
without importing another crate (`CfgPath`, `DataReader`,
`DataWriter`). This has been fixed.
- In addition, the doc comments for `DataReader` and `DataWriter` were
cleaned up to be of better quality, now that they're public.
- It was impossible to use `arti-client` without also importing
`tor-rtcompat`. This is now fixed by the addition of two convenience
methods: `TorClient::bootstrap_with_tokio` and
`TorClient::bootstrap_with_async_std`.
- Potentially controversially: `tor-rtcompat` now returns *concrete*
types from methods like `current_runtime`, instead of `impl Runtime`.
- This was needed in order to actually be able to name the `TorClient`
type that results from using these methods.
- This does mean we lose API flexibility, but on balance I think this
is a good thing, because the API we *do* have is actually usable...