mirrors/arti.git/crates/tor-proto/src/stream, branch arti-v1.2.4

proto: Try to clarify why StreamReader has a StreamTarget.

2024-05-29T11:28:05Z

proto: Improve documentation about DataStream lifetimes and closing

2024-05-29T11:28:05Z

In particular, clarify that dropping the DataWriter on its own does nothing unless the DataReader is also dropped. Related to #1368.

proto: Make DataWriter::close actually do something.

2024-05-29T11:28:01Z

Previously we had a bug where `::close` (or `shutdown` in tokio-land) would not actually have any effect. It _would_ drop the `StreamTarget` held by the `DataWriter`, but since the `DataReader` also held a `StreamTarget`, the MPSC channel would not get closed, and the circuit reactor would not realize that the stream wanted to shut down. Now we use `mpsc::Sender::close_channel` to make our closes effectual. Closes #1368. Additionally, we fix a bug where `poll_close()` never actually did anything if the buffer had nothing in it when it was called. Previously, `poll_flush_impl()` would exit immediately if it had no data to flush. That isn't what we want when we are closing!

proto: Explicitly enforce maxima on SENDME windows.

2024-05-14T14:36:05Z

No actual bug here, just technical debt: For `SendWindow`s, our tag system already ensured that we rejected any SENDME that didn't correspond to an appropriate drain. Still, it doesn't hurt to check. For `RecvWindow`s, it would have been a protocol violation if we ever did this, but it makes sense to make it an internal error if we try. Part of #1383.

proto: Fix compilation with stream-ctrl but not experimental-api.

2024-05-14T12:04:03Z

proto: Expose wait_for_connection as a part of the DataStream API.

2024-05-09T20:34:17Z

Rename the old IncomingStreamRequestContext to StreamReqInfo.

2024-03-26T16:55:05Z

(Doing this to prevent us having two structs with the same name.)

Add an IncomingStreamRequestFilter to check early properties

2024-03-26T16:55:05Z

Based on designs in #1124. Note that there is a TODO here about a hack I had to do to appease the borrow checker.

Run maint/add_warning.

2024-03-13T16:30:53Z

relay-cell: Update relay cell decoding API for prop340

2024-03-12T15:58:12Z

Prop 340: https://spec.torproject.org/proposals/340-packed-and-fragmented.html This updates the decoding API to support multiple versions of the relay cell encoding, including the new encoding proposed in prop340 that supports relay message packing and fragmentation. This commit doesn't actually add support for that new encoding yet.