mirrors/arti.git/crates/tor-proto/src/stream, branch arti-v1.1.9 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.9 2023-08-23T13:59:02Z tor-proto: Make some imports more precise 2023-08-23T13:59:02Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-23T13:57:21Z urn:sha1:d5fce95e1ebadbc3837aee32b4a19c2d4a7247d0 A warning is getting in my way when I run cargo clippy -p tor-hsservice --all-features See also https://gitlab.torproject.org/tpo/core/arti/-/issues/1006#note_2932088 tor-proto: Make update_state() and discard() return Result<(), Bug>. 2023-08-09T12:07:35Z Gabriela Moldovan gabi@torproject.org 2023-08-09T12:07:35Z urn:sha1:6073a4f7679251ff7e97501cd4a85fa92d12355d These functions only ever return `Bug` errors. tor-proto: Implement IncomingStream::discard(). 2023-08-08T14:25:45Z Gabriela Moldovan gabi@torproject.org 2023-08-08T14:18:27Z urn:sha1:a0daa9adb6b99c516835108cfe13512cff50bb13 tor-proto: Replace boolean flags with an IncomingStreamState enum. 2023-08-08T14:25:42Z Gabriela Moldovan gabi@torproject.org 2023-08-08T14:13:27Z urn:sha1:4507c33479b048344b19e55f057b46b903d26c4c This commit introduces an `IncomingStreamState` enum, which indicates whether the stream was accepted, discarded, or rejected, or if it is still pending. The `is_rejected`/`is_accepted` boolean flags are no longer needed. Without this change, we'd need to introduce yet another boolean flag when we implement `discard()` (for the "discarded" state). Merge branch 'tor-proto-incoming-todo' into 'main' 2023-08-08T13:13:31Z gabi-250 gabi@torproject.org 2023-08-08T13:13:31Z urn:sha1:fa595875ecb43fed82a193c2df3dd28ba5ea2256 tor-proto: Replace IncomingStreamMsg with IncomingStreamRequest. See merge request tpo/core/arti!1477 tor-proto: Fix broken docs. 2023-08-08T12:14:39Z Gabriela Moldovan gabi@torproject.org 2023-08-08T12:14:39Z urn:sha1:7446ed08b6f590eb3e62b2fa9c44a9ea758c6220 tor-proto: Make it obvious that we're discarding a Result. 2023-08-08T12:07:45Z Gabriela Moldovan gabi@torproject.org 2023-08-08T12:07:45Z urn:sha1:a74e4cf661355cfb9a2b7fa800612cf8125d4345 tor-proto: Make StreamTarget::close return the oneshot::Receiver instead of blocking. 2023-08-08T12:04:01Z Gabriela Moldovan gabi@torproject.org 2023-08-08T12:04:01Z urn:sha1:4fb5121a77c42ce094b736c1f6f49ec72185be37 Instead of having 2 version of `StreamTarget::close` (a blocking one and a nonblocking one), we can just return the `oneshot::Receiver` for receiving the reactor's response and let the caller of `StreamTarget::close` decide whether to block. This allows us to reduce some code duplication in the `IncomingStream` implementation. tor-proto: Make take_inner() use mut_inner() to check the inner value. 2023-08-08T11:47:13Z Gabriela Moldovan gabi@torproject.org 2023-08-08T11:47:13Z urn:sha1:2b2f0f606592badcbfa2de3f971f6b4434a96483 tor-proto: Replace IncomingStreamMsg with IncomingStreamRequest. 2023-08-07T15:45:49Z Gabriela Moldovan gabi@torproject.org 2023-08-07T15:45:49Z urn:sha1:41fab65de12445d772aba0a1131e1549c873316f The two enums essentially serve the same purpose, so we don't need both of them. This also addresses the TODO that says we should return an error if `accept_data` is called for a RESOLVE stream.