mirrors/arti.git/crates/tor-proto/src/stream, branch arti-v1.1.11

Send less information in onion service BEGIN messages

2023-11-15T18:21:11Z

While looking for differences, we found that C tor always omits the flags and the hostname from a BEGIN message sent on an onion service circuit. In torspec!179, we specified that behavior. This patch brings arti into conformance. Closes #1077.

Convert StreamId to NonZeroU16

2023-10-25T20:34:55Z

proto: Revise the behavior of IncomingStream::discard().

2023-10-19T17:15:10Z

Because dropping a `StreamTarget` causes the circuit reactor to send an End, the previous do-nothing implementation of `discard()` wasn't sufficient to cause the request to be ignored without sending an End. This commit modifies our "close pending stream" behavior to only optionally send an End message. To avoid confusion, I'm using a new `CloseStreamBehavior` enum rather than an `Option`, since we had previously used `None` in some cases to indicate a default (misc) end message.

IncomingStream:: flatten IncomingStreamInner.

2023-10-19T17:15:10Z

IncomingStream: Remove state.

2023-10-19T17:15:10Z

Now that every state-change function consumes the IncomingStream, there is no longer any reason to keep track of an internal state enum.

Note a bug in IncomingStream::discard.

2023-10-19T17:15:10Z

Remove IncomingStreamInner from its Option.

2023-10-19T17:15:10Z

Now that IncomingStream doesn't implement Drop, we can just destructure it.

Remove impl Drop from IncomingStream

2023-10-19T17:15:10Z

Since dropping a StreamTarget will send an End, we don't need to call reject_internal in this case.

proto: Make StreamTarget::close() misuse less likely.

2023-10-17T12:41:44Z

It turns out that we can make `IncomingStream::reject()` consume self, thus making it impossible to hit the double-close error from outside the `tor-proto` crate. Also, we rename `StreamTarget::close()` to `close_pending()` to better reflect its limited applicability.

proto::stream::incoming: Use bit-array representation for command list

2023-10-12T16:23:58Z

This should be smaller and faster than vec, and save some allocations. It could also avoid a tiny sidechannel.