mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks 2023-02-27T13:14:15Z 2023-02-27T13:14:15Z Nick Mathewson nickm@torproject.org 2023-02-27T13:14:15Z urn:sha1:07473ed1fc110b8b48ef02bb288b1f50085dfa06 2023-02-17T16:50:27Z Nick Mathewson nickm@torproject.org 2023-02-17T16:50:27Z urn:sha1:c5be3c089efc75453762ea975a9a96e6560057dc The role of CmdChecker is to verify that messages are arriving at the appropriate sequence on a stream, with respect to the other messages that have been received. Once the stream becomes half-closed, the CmdChecker is also in charge of consuming incoming messages on the stream and making sure that they are well-formed. 2023-02-15T15:48:19Z Nick Mathewson nickm@torproject.org 2023-02-13T22:48:33Z urn:sha1:41b50b6c56debc1eeb644d65b2738645bf98fce7 This closes #525, and ensures, at last, that we don't parse any message that we wouldn't accept. 2023-02-07T21:03:14Z Nick Mathewson nickm@torproject.org 2023-02-07T14:18:17Z urn:sha1:d63d7926bd5e94f4129dd1a44e696728125a6c4a Thanks to rust-analyzer for making this simple. 2023-02-07T21:03:14Z Nick Mathewson nickm@torproject.org 2023-02-07T13:56:09Z urn:sha1:c529bb9c307ffd90d138bffc8ed4e2a45db9c4e3 2021-11-12T15:04:27Z eta tor@eta.st 2021-11-11T17:44:50Z urn:sha1:c559754116678866eabe525f5b189b50cc78b5cc Previously, the reactor would use an `UnboundedSender` to send things to the `RawCellStream`, in order that the reactor wouldn't block if you failed to read from the latter. This is bad, though, since it means people can just run us out of memory by sending lots of things. To fix this, we make the new `StreamReader` type (which does the reading parts from `RawCellStream`) keep track of the stream's receive window and issue SENDMEs once *it* has consumed enough data to require it, thus meaning that we shouldn't get sent enough data to fill the channel between reactor and `StreamReader` (and, if we do, that's someone trying to flood us, and we abort the circuit). As hinted to above, the `RawCellStream` was removed and its reading functionalities replaced by `StreamReader`; its writing functionalities are handled by `StreamTarget` anyway, so we just give out one of those for the write end. This now means we don't need any mutexes! note: this commit introduces a known issue, arti#230 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing.