mirrors/arti.git/crates/tor-proto/src/stream/incoming.rs, branch arti-v1.1.13

Rename {Any}RelayCell to {Any}RelayMsgOuter

2023-12-14T16:56:58Z

This commit is pure renaming, done automatically with rust-analyzer. Comment fixes and other cleanups will be in the subsequent commits. We're doing this renaming because we need a name for the combination of a `RelayMsg` and an `Option` that we use when we have a `RelayMsg` we intend to route to a given stream or circuit internally. Previously we called this a `RelayCell`, but that name was already somewhat inaccurate, and will become _very_ inaccurate with the arrival of prop340, which breaksthe 1:1 relationship between relay cells and relay messages. (If we didn't do this renaming now, we'd soon be making the relationship between `UnparsedRelayCell`and `RelayCell` many-to-many, which would be ridiculous and confusing.) The `RelayMsgOuter` name is a placeholder: We expect that we'll want to rename this type, and may also want to rename `RelayMsg`, and unify our vocabulary in other areas too. But such a renaming will have to wait for a larger discussion affecting the specifications, so that we can use the same vocabulary everywhere.

Convert StreamId to NonZeroU16

2023-10-25T20:34:55Z

proto: Revise the behavior of IncomingStream::discard().

2023-10-19T17:15:10Z

Because dropping a `StreamTarget` causes the circuit reactor to send an End, the previous do-nothing implementation of `discard()` wasn't sufficient to cause the request to be ignored without sending an End. This commit modifies our "close pending stream" behavior to only optionally send an End message. To avoid confusion, I'm using a new `CloseStreamBehavior` enum rather than an `Option`, since we had previously used `None` in some cases to indicate a default (misc) end message.

IncomingStream:: flatten IncomingStreamInner.

2023-10-19T17:15:10Z

IncomingStream: Remove state.

2023-10-19T17:15:10Z

Now that every state-change function consumes the IncomingStream, there is no longer any reason to keep track of an internal state enum.

Note a bug in IncomingStream::discard.

2023-10-19T17:15:10Z

Remove IncomingStreamInner from its Option.

2023-10-19T17:15:10Z

Now that IncomingStream doesn't implement Drop, we can just destructure it.

Remove impl Drop from IncomingStream

2023-10-19T17:15:10Z

Since dropping a StreamTarget will send an End, we don't need to call reject_internal in this case.

proto: Make StreamTarget::close() misuse less likely.

2023-10-17T12:41:44Z

It turns out that we can make `IncomingStream::reject()` consume self, thus making it impossible to hit the double-close error from outside the `tor-proto` crate. Also, we rename `StreamTarget::close()` to `close_pending()` to better reflect its limited applicability.

proto::stream::incoming: Use bit-array representation for command list

2023-10-12T16:23:58Z

This should be smaller and faster than vec, and save some allocations. It could also avoid a tiny sidechannel.