mirrors/arti.git/crates/tor-proto/src/stream/data.rs, branch arti-v1.4.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.02025-01-30T16:11:01Zproto: deprecate DataStream::circuit2025-01-30T16:11:01ZNick Mathewsonnickm@torproject.org2025-01-30T16:07:59Zurn:sha1:d0e07702225cc0c9f829f1db1c571e8c2ffee4c3
This method is experimental, so no semver note is needed.
It is redundant with `client_stream_ctrl()?.circuit()?`.
(The name and the unconditional return type of this method
are probably an error.)
proto: Rename (experimental) DataStream functions for ctrl access2025-01-30T16:11:01ZNick Mathewsonnickm@torproject.org2025-01-30T15:48:45Zurn:sha1:01197344045835a2e901cf68488332bf3c8ccd56
Since these return a client-specific type,
they need a client-specific name before we can stabilize them for RPC.
proto: Rename ClientDataStreamCtrl::{is_open=>is_connected}2025-01-30T16:11:01ZNick Mathewsonnickm@torproject.org2025-01-30T15:41:48Zurn:sha1:f0f5e3f43c3fc3de23e83dc97f162e783f03edbd
Semantically, the new name matches the behavior much better.
(A stream could well count as open if we had sent a RESOLVE but not
received a RESOLVED, so we might someday want to have an `is_open`
defined for _all_ streams, not just data streams.)
proto: Rename DataStreamCtrl to ClientDataStreamCtrl2025-01-30T16:11:01ZNick Mathewsonnickm@torproject.org2025-01-30T15:31:51Zurn:sha1:af6ba7ea0379e2129e1cef1952d193f6783c5bbb
The API for this type, and the fact that it implements
ClientStreamCtrl unconditionally, means that it is only for client
DataStreams.
memquota: Use _ rather than allow(dead_code)2024-10-22T12:19:22ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-22T12:16:26Zurn:sha1:eed28245887b87a7bf1e884b568f8062148cdd76
Promote the associated comments.
As suggested here:
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2560#note_3097188
memquota: fix data stream account lifetime2024-10-21T10:11:20ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-16T15:57:44Zurn:sha1:6092b87c6a2351dfcf90e7f81505b06820e95eaf
The DataStream is sometimes disassembled, eg by split. When that
happens, the StreamAccount would be dropped - and that was the only
strong reference.
Put a StreamAccount in each of the pieces, instead of just in the
combined DataStream struct.
tor-proto: Put a StreamAccount in DataStream etc.2024-10-03T14:10:47ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-02T15:42:18Zurn:sha1:7b97ce4ee6d9f7eb42646f870feb7bde42001ad6tor-proto: Put a StreamAccount in DataStream etc. (pre-fmt)2024-10-03T14:10:47ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-02T15:42:11Zurn:sha1:b327b0cd620c674a2c89a8d259d2c701ad24befdproto: Try to clarify why StreamReader has a StreamTarget.2024-05-29T11:28:05ZNick Mathewsonnickm@torproject.org2024-05-28T20:42:20Zurn:sha1:b077b68e6dc9d426beebd84bd63382287c03b02fproto: Improve documentation about DataStream lifetimes and closing2024-05-29T11:28:05ZNick Mathewsonnickm@torproject.org2024-05-28T16:52:56Zurn:sha1:99dcd037aa81863da56180900e8b6f0aeb143f2d
In particular, clarify that dropping the DataWriter on its own does
nothing unless the DataReader is also dropped.
Related to #1368.