mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.5 2023-05-22T15:27:44Z 2023-05-22T15:27:44Z Nick Mathewson nickm@torproject.org 2023-05-22T15:15:14Z urn:sha1:0df0cf425032ff05d0d405d82436cbfd86faf3ac The idea here is that we want to make DataStream visible to the RPC system without requiring that the RPC session hold the DataStream itself (or the Reader, or the Writer). We could solve this problem by making _all_ the state in the DataStream shared, but that would introduce unnecessary extra locking in our critical path. Instead we're creating the notion of a "control handle" that lets you manage and observe a stream without actually owning the stream. Right now the only supported functionality is asking for the stream's circuit. Part of #847 2023-02-28T11:10:17Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-02-24T14:26:25Z urn:sha1:f63c7c48afd94fe9d09746f0b76fbaff8d4a1a79 Fixes #756 2023-02-17T16:50:27Z Nick Mathewson nickm@torproject.org 2023-02-17T16:50:27Z urn:sha1:c5be3c089efc75453762ea975a9a96e6560057dc The role of CmdChecker is to verify that messages are arriving at the appropriate sequence on a stream, with respect to the other messages that have been received. Once the stream becomes half-closed, the CmdChecker is also in charge of consuming incoming messages on the stream and making sure that they are well-formed. 2023-01-17T20:20:03Z Nick Mathewson nickm@torproject.org 2023-01-11T19:43:43Z urn:sha1:12845d6e1ede396cd85fbacec3656b926e0896bc Onion services (and later, exits and caches) will need this. 2022-01-11T15:16:03Z eta tor@eta.st 2022-01-11T15:16:03Z urn:sha1:41e202a3a4c582dedd2c9c5c5c60369b4a53fae0 This commit addresses multiple problems highlighted by arti#182: - `arti-client` had some types in its public API that weren't accessible without importing another crate (`CfgPath`, `DataReader`, `DataWriter`). This has been fixed. - In addition, the doc comments for `DataReader` and `DataWriter` were cleaned up to be of better quality, now that they're public. - It was impossible to use `arti-client` without also importing `tor-rtcompat`. This is now fixed by the addition of two convenience methods: `TorClient::bootstrap_with_tokio` and `TorClient::bootstrap_with_async_std`. - Potentially controversially: `tor-rtcompat` now returns *concrete* types from methods like `current_runtime`, instead of `impl Runtime`. - This was needed in order to actually be able to name the `TorClient` type that results from using these methods. - This does mean we lose API flexibility, but on balance I think this is a good thing, because the API we *do* have is actually usable... 2021-11-12T15:04:27Z eta tor@eta.st 2021-11-11T17:44:50Z urn:sha1:c559754116678866eabe525f5b189b50cc78b5cc Previously, the reactor would use an `UnboundedSender` to send things to the `RawCellStream`, in order that the reactor wouldn't block if you failed to read from the latter. This is bad, though, since it means people can just run us out of memory by sending lots of things. To fix this, we make the new `StreamReader` type (which does the reading parts from `RawCellStream`) keep track of the stream's receive window and issue SENDMEs once *it* has consumed enough data to require it, thus meaning that we shouldn't get sent enough data to fill the channel between reactor and `StreamReader` (and, if we do, that's someone trying to flood us, and we abort the circuit). As hinted to above, the `RawCellStream` was removed and its reading functionalities replaced by `StreamReader`; its writing functionalities are handled by `StreamTarget` anyway, so we just give out one of those for the write end. This now means we don't need any mutexes! note: this commit introduces a known issue, arti#230 2021-11-10T16:04:55Z Nick Mathewson nickm@torproject.org 2021-11-10T16:04:55Z urn:sha1:5287ac1858ed3abceb7c0ec803e76b130bb27f96 It seems like a good time to do this, before we add a zillion other arguments to begin_stream. 2021-10-27T15:13:46Z Nick Mathewson nickm@torproject.org 2021-10-27T15:13:46Z urn:sha1:134c04a67adebff719011b608dabfa6da60ed247 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing.