mirrors/arti.git/crates/tor-proto/src/relay, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-08-19T17:27:23Ztor-proto: add `StreamHandler::flowctrl_sidechannel_mitigations()`2026-08-19T17:27:23ZSteven Engleropara@torproject.org2026-08-19T17:27:23Zurn:sha1:f32fbb29337808e98ac3832a04bcb8e77f65b749proto: Extend test to check DESTROY is sent to the next hop2026-08-18T16:13:57ZGabriela Moldovangabi@torproject.org2026-08-18T10:18:44Zurn:sha1:d849b8b84285eb7ae579c0f58988f8be06cde4e4
This extends the `destroy_from_client()` test to also check that a
DESTROY received from the client (or, more generally speaking, from the
"inbound channel") is actually forwarded to the next hop.
The reason the `assert_destroy_sent()` assertion is commented out is
specified in the TODO that precedes it (tldr: testing the DESTROY
behaviour involves both the channel reactor and the circuit reactor, and
our test setup is currently quite limited, in that it doesn't actually
exercise the right channel reactor code paths for the *inbound*
channel). I plan to address this soon.
proto: Move assert_cell_is_destroy macro out of helper function2026-08-18T16:13:57ZGabriela Moldovangabi@torproject.org2026-08-18T10:16:56Zurn:sha1:5a34a40326a1d1e014725bac526a4505f4cf7691
I am about to need this in a test.
proto: Add comments explaining why the tests use DestroyDirection::Backward2026-08-18T16:13:57ZGabriela Moldovangabi@torproject.org2026-08-18T10:09:45Zurn:sha1:fa6e21cc03b008662cc906ae59f639ba9985368cproto: Remove misleading comment and rename misnamed variable2026-08-18T16:13:57ZGabriela Moldovangabi@torproject.org2026-08-18T10:08:43Zurn:sha1:f0266082010685d29be0c7f386b116adb2467581
This fixes an old bad copy-paste that I've just noticed.
proto: Clarify what read_{inbound,outbound} are for2026-08-18T16:13:57ZGabriela Moldovangabi@torproject.org2026-08-18T09:42:15Zurn:sha1:e9e6cf8a3047bb4d222894969f9a1fba4a710acc
This adds an example suggested by opara.
proto: Update the tests to check DESTROY is only sent when needed2026-08-18T16:13:57ZGabriela Moldovangabi@torproject.org2026-08-13T16:27:41Zurn:sha1:8bcc721b73efafbf1a0ca95610afb044434f07a5proto: Allocate a real circ id in the circ reactor tests2026-08-18T16:13:57ZGabriela Moldovangabi@torproject.org2026-08-13T15:39:16Zurn:sha1:1d0cfbba5bc27dc5f969941819d29706514df738
We need this because the channel reactor now only sends DESTROY for
circuits that are still in the circ map (and we are about to test this
behaviour, so we need the circuit map to actually have an entry for our
test circuit).
Initially, these tests were meant to test the circuit reactor in
isolation, but they've gradually grown more complex, and now require
a semi-working channel reactor. In the long run, I think I'd like to:
* change the tests from `tor_proto::relay::reactor` to use a proper
relay channel reactor as opposed to a `working_dummy_channel()`, and
to initialize a circuit through the normal means, namely by sending
a CREATE2 through the channel reactor (naturally, this "proper relay
channel reactor" still wouldn't be connected to the network). These
will test the integration between the channel and the circuit
reactor, as well as the circuit reactor behaviour
* add new, implementation-agnostic tests for the generic multi-reactor
system. These will use a mock channel reactor
proto: Update create handler tests to no longer expect DESTROY2026-08-18T16:13:57ZGabriela Moldovangabi@torproject.org2026-08-13T14:49:22Zurn:sha1:9857a5bbe5483e2130c6a8a5108350aa7cb7f114
Now that we no longer respond to DESTROY by sending a DESTROY ourselves,
these tests need to be updated.
proto: s/client/next hop in test comment2026-08-18T16:13:57ZGabriela Moldovangabi@torproject.org2026-08-13T14:40:07Zurn:sha1:93f0d89002f5328e1008a7d1c38f1a578f7a1f96
This test simulates the *next hop* sending us a DESTROY.