mirrors/arti.git/crates/tor-proto/src/relay/channel.rs, branch arti-v2.0.0

proto: Improve some comments in relay module

2026-01-22T16:16:44Z

Signed-off-by: David Goulet

proto: Fix the link auth handling from the AUTH_CHALLENGE

2026-01-22T16:16:44Z

Signed-off-by: David Goulet

proto: Use the channel codec channel type

2026-01-22T16:16:44Z

Remove the channel type from Unverified and Verified channels and instead use the channel type in the underlying channel codec. The codec requires such type in order to restrict messages sets. Instead of duplicating it, this commit simply makes it that there is now only a single channel type attached to a channel structure. The resulting `struct Channel` in the end gets it copied from the channel codec as the framed_tls gets split and given to the `Reactor`. Down the line, we need a channel type attached to the `Channel` in order to know if it is a client or not and authenticated or not. Signed-off-by: David Goulet

proto: Improve comments on build_auth_data() about clog/slog

2026-01-22T16:16:44Z

Signed-off-by: David Goulet

proto: Remove Option<> around peer_ip for build_netinfo_cell()

2026-01-22T16:16:44Z

Signed-off-by: David Goulet

proto: Put rsa_id and rsa_cert_digest together

2026-01-22T16:16:44Z

Avoid having one None and the other Some which would be a bug. Signed-off-by: David Goulet

proto: Avoid magic hardcoded value for LINK_AUTH

2026-01-22T16:16:44Z

Instead, use the static AUTHTYPE_ED25519_SHA256_RFC5705 value which is for now the only version we support. Signed-off-by: David Goulet

proto: Remove async for VerifiableChannel::check()

2026-01-22T16:16:44Z

Signed-off-by: David Goulet

proto: Move cell sending out of check() and into finish()

2026-01-22T16:16:44Z

This is so check() only authenticate a channel. The finish() function now only sends back the missing cells and build the final Channel. To pull this off, the AUTHENTICATE cell and our IP addresses need to be copied into the VerifiedRelayChannel. This allows us to remove complexity into the check() function as well and future commit will remove the async. Signed-off-by: David Goulet

proto: Implement FinalizableChannel for an unverified relay channel

2026-01-22T16:16:44Z

Reason for this is so we can use the type system to enforce that a client/bridge<-> relay channel can never become verified and thus in the code path of authentication. In other words, when check() is called, without an authentication cell, we can't authenticate or even verify the identities so we immediately return "self" which in this case is the UnverifiedRelayChannel. That channel can be finish()-ed to yield a Channel that can never be considered authenticated. Signed-off-by: David Goulet