mirrors/arti.git/crates/tor-proto/src/crypto, branch arti-v1.2.8mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.82024-09-16T15:00:43Ztor-proto: Use Reader::take_all_but().2024-09-16T15:00:43ZNick Mathewsonnickm@torproject.org2024-09-12T12:49:06Zurn:sha1:17927a8c9a13e027961b62b3c787387e8ed6f2e5tor-bytes: Error: provide and call Error::incomplete_error2024-09-11T13:19:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T11:32:08Zurn:sha1:12c2fbe076cfcff8d734b24d6aef243d09c64d15
We introduce the new constructor and call it at the error generation
sites. But there is still not yet any functional change.
Change the type of Truncated's field to be Sensitive.
The original reason for not doing this no longer applies, since we
don't generally want to open-code construction of this variant.
Conveniently, changing the type means we get to find all the sites
where one *is* constructed and adjust them.
In reader.rs and tor-proto we can just call incomplete_error.
In tor-cell, there's a call site where we previously provided an
underestimate, and where the Reader isn't available. We adjust that
ad-hoc but this is fine because the error variant will
change. (relaycell is using a Reader from from_slice.)
tor-bytes: Add a deficit field to Error::Truncated (fmt)2024-09-10T09:10:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-05T16:04:59Zurn:sha1:3642336ad06998f8eb8228883abc17a04186534dtor-bytes: Add a deficit field to Error::Truncated2024-09-10T09:10:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-05T15:48:39Zurn:sha1:2ae6523dbfc6f3b26ffdc2465f93afab6de3c542
This will allow us to fix #1592, but it doesn't do so yet.
Add allows for many dead code warnings in tor-proto2024-07-08T10:36:25ZIan Jacksonijackson@chiark.greenend.org.uk2024-07-08T10:15:29Zurn:sha1:44a0dc628994dbea5eb8113fac38fbc50ad01896
I'm not sure how to resolve these. See #1467.
We ought to fix them before they propagate to +stable, particularly
since after !2242 they'll break CI.
Add temporary allows for some dead code warnings2024-04-25T14:22:32ZIan Jacksonijackson@chiark.greenend.org.uk2024-04-24T10:51:54Zurn:sha1:2308e88a9a9e308f28b9a60d9efed6ad3cd603fbUse uXX::MAX in place of std::uXX::MAX2024-04-22T17:00:29ZNick Mathewsonnickm@torproject.org2024-04-22T17:00:29Zurn:sha1:4a1ad1dc89f6a9f48c84411560c1617d9e487abc
The old code produced a warning from clippy nightly; we may as well
update to use the new associated consts. (They've been there since
Rust 1.4x.)
proto: Simplify a check-and-convert to use try_into+expect2024-04-22T16:59:16ZNick Mathewsonnickm@torproject.org2024-04-22T16:59:16Zurn:sha1:98bd5a6ebfc82ba25a088df237cd759ec5064cfdAdd and use RelayCellFormatTrait2024-03-20T14:10:32ZJim Newsomejnewsome@torproject.org2024-03-19T00:30:12Zurn:sha1:8a91f277bbb9faa263a33d6b270f652a0da98068
This lets us paramaterize types and functions by a particular relay cell
format. We use this e.g. to statically parameterize the cell crypto
functions, thereby removing some run-time branching in the hot path.
Propagate RelayCellFormat selection up to where format decisions will be made2024-03-20T14:08:27ZJim Newsomejnewsome@torproject.org2024-03-14T19:24:40Zurn:sha1:2da3c95fc744db6248c077f35a7b3c328bfdf55a