mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.10 2023-10-31T11:40:36Z 2023-10-31T11:40:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-10-31T11:32:51Z urn:sha1:a49a2cdf22518bd69be5058463fbc57301211a5d Peraonally I would prefer | #![cfg_attr(not(all(feature = "full", feature = "experimental")), | allow(dead_code))] but I think that is almost certainly controversial. See tpo/core/arti#704. 2023-10-12T16:43:00Z Nick Mathewson nickm@torproject.org 2023-10-12T16:43:00Z urn:sha1:2872a88cb065b10218f74c7306e93c354a3c048f tor-proto: Resolve a few TODO HSS entries. See merge request tpo/core/arti!1658 2023-10-12T13:59:42Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-10-10T12:51:32Z urn:sha1:d6a1cfb84aa8060ba17d9c2a25a3396501d0e004 2023-10-12T13:20:44Z Nick Mathewson nickm@torproject.org 2023-10-12T13:17:38Z urn:sha1:4c88561eb979a43253422a2584b38b98b4827637 This will let avoid some copying inside our HSS code. 2023-10-03T12:48:16Z Nick Mathewson nickm@torproject.org 2023-10-03T12:48:16Z urn:sha1:5fed9fa0ebd02ed8139407b4473a01c93e408ebd tor-proto: Refactor the key derivation See merge request tpo/core/arti!1629 2023-10-03T11:05:26Z Gabriela Moldovan gabi@torproject.org 2023-10-02T10:13:24Z urn:sha1:399d4c8d27f1da600851d10fb1a8482b818b0fbd 2023-09-29T06:09:05Z Emil Engler me@emilengler.com 2023-09-29T06:09:05Z urn:sha1:295c565944da864925daad3cfab12de010e97690 This commit refactors the key derivation, by applying the following: - The spaghetti slice creation with the hard-to-read boundaries got replaced by a closure, which accepts a length, advances the seed slice by n bytes as a side-effect, and returns the just advanced bytes - The use of `.except` got replaced by an `.or`, with the use of the already existing `InvalidKDFOutputLength` error, thereby removing a potential panic (probably not reachable in runtime though) - The conversion from a slice to a `CircuitBinding` got moved into a `TryFrom` trait of the appropriate data structure 2023-09-28T15:35:00Z Nick Mathewson nickm@torproject.org 2023-09-28T15:35:00Z urn:sha1:f6135ebf903a2210b7023d01923641fece4350be Upgrade several dependencies See merge request tpo/core/arti!1626 2023-09-28T15:00:44Z Emil Engler me@emilengler.com 2023-09-28T15:00:44Z urn:sha1:9224d55e9956c13da6386bbb8a13f1373f4c69a3 This commit replaces a repeating code pattern in the `set_digest` function for setting the 'Recognized' and Digest field to zero with a slice fillment. Besides this, it also adds comments explaining which fields are currently getting zeroized. 2023-09-28T14:59:29Z Nick Mathewson nickm@torproject.org 2023-09-28T14:15:47Z urn:sha1:34766342614bb4ca5742ee041273e99ff690ed20 Instead of tying ourselves to a particular version of the generic-array crate, we now always use the version re-exported by our RustCrypto crates. This lets us avoid the possibility of version mismatch. (Originally I had planned to upgrade to generic-array 1.0, but then I found that we were not actually using it.)