mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.4 2022-01-01T19:14:29Z 2022-01-01T19:14:29Z Daniel Eades danieleades@hotmail.com 2022-01-01T19:14:29Z urn:sha1:d68e934716844733d70f0e7c84f8d07c2d77b3d5 2021-12-08T17:39:02Z Nick Mathewson nickm@torproject.org 2021-12-08T17:39:02Z urn:sha1:9a8c91bdf875e553bea19f01f24942b703db9f84 2021-12-08T16:38:56Z Neel Chauhan neel@neelc.org 2021-12-07T23:03:08Z urn:sha1:2d915ed68444c49c0a99f2c157446d68f8cc77b5 2021-12-08T01:33:46Z Nick Mathewson nickm@torproject.org 2021-12-08T01:33:46Z urn:sha1:4536c2ac873ca7fc490bd65965bbfe41e705cda9 We generally try to track the latest rust-crypto traits when we can: fortunately, this upgrade didn't break much, considering. 2021-12-07T16:21:48Z Nick Mathewson nickm@torproject.org 2021-12-07T16:21:48Z urn:sha1:36f6a61f05d52886c482613382f8643cebc2bbd5 There is now a ticket about this issue in general, at arti#254. 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231. 2021-11-30T13:51:03Z dagon dagon12@tutanota.com 2021-11-30T13:51:03Z urn:sha1:0c10f4ea0b6e9c83823535f956e11de1beb4e3bc 2021-11-25T13:20:37Z Daniel Eades danieleades@hotmail.com 2021-11-25T13:14:05Z urn:sha1:db16d13df4779ac61005050dfe5ce05e3d5a1b5d 2021-11-12T15:04:24Z eta tor@eta.st 2021-11-09T14:05:31Z urn:sha1:197816d14cfb24c8830b938dac7dc3afb6eb6c26 Rather like e8e9699c3c239d6c30f9ad414f15d3bad6ec03fd ("Get rid of tor-proto's ChannelImpl, and use the reactor more instead"), this admittedly rather large commit refactors the way circuits in `tor-proto` work, centralising all of the logic in one large nonblocking reactor which other things send messages into and out of, instead of having a bunch of `-Impl` types that are protected by mutexes. Congestion control becomes a lot simpler with this refactor, since the reactor can manage both stream- and circuit-level congestion control unilaterally without having to share this information with consumers, meaning we can get rid of some locks. The way streams work also changes, in order to facilitate better handling of backpressure / fairness between streams: each stream now has a set of channels to send and receive messages over, instead of sending relay cells directly onto the channel (now, the reactor pulls messages off each stream in each map, and tries to avoid doing so if it won't be able to forward them yet). Additionally, a lot of "close this circuit / stream" messages aren't required any more, since that state is simply indicated by one end of a channel going away. This should make cleanup a lot less brittle. Getting all of this to work involved writing a fair deal of intricate nonblocking code in Reactor::run_once that tries very hard to be mindful of making backpressure work correctly (and congestion control); the old code could get away with having tasks .await on things, but the new reactor can't really do this (as it'd lock the reactor up), so has to do everything in a nonblocking manner. 2021-11-02T13:50:55Z Nick Mathewson nickm@torproject.org 2021-11-02T13:50:55Z urn:sha1:cdae4c033cb983fc21161133772dfa47189b2694