mirrors/arti.git/crates/tor-proto/src/crypto/handshake, branch arti-v1.3.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.02024-09-16T15:00:43Ztor-proto: Use Reader::take_all_but().2024-09-16T15:00:43ZNick Mathewsonnickm@torproject.org2024-09-12T12:49:06Zurn:sha1:17927a8c9a13e027961b62b3c787387e8ed6f2e5tor-bytes: Error: provide and call Error::incomplete_error2024-09-11T13:19:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T11:32:08Zurn:sha1:12c2fbe076cfcff8d734b24d6aef243d09c64d15
We introduce the new constructor and call it at the error generation
sites. But there is still not yet any functional change.
Change the type of Truncated's field to be Sensitive.
The original reason for not doing this no longer applies, since we
don't generally want to open-code construction of this variant.
Conveniently, changing the type means we get to find all the sites
where one *is* constructed and adjust them.
In reader.rs and tor-proto we can just call incomplete_error.
In tor-cell, there's a call site where we previously provided an
underestimate, and where the Reader isn't available. We adjust that
ad-hoc but this is fine because the error variant will
change. (relaycell is using a Reader from from_slice.)
tor-bytes: Add a deficit field to Error::Truncated (fmt)2024-09-10T09:10:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-05T16:04:59Zurn:sha1:3642336ad06998f8eb8228883abc17a04186534dtor-bytes: Add a deficit field to Error::Truncated2024-09-10T09:10:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-05T15:48:39Zurn:sha1:2ae6523dbfc6f3b26ffdc2465f93afab6de3c542
This will allow us to fix #1592, but it doesn't do so yet.
Add allows for many dead code warnings in tor-proto2024-07-08T10:36:25ZIan Jacksonijackson@chiark.greenend.org.uk2024-07-08T10:15:29Zurn:sha1:44a0dc628994dbea5eb8113fac38fbc50ad01896
I'm not sure how to resolve these. See #1467.
We ought to fix them before they propagate to +stable, particularly
since after !2242 they'll break CI.
Run maint/add_warning.2024-03-13T16:30:53ZNick Mathewsonnickm@torproject.org2024-03-13T16:30:53Zurn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320cNtorV3Extension set encoding/decoding: include n_extensions2023-12-07T15:45:45ZJim Newsomejnewsome@torproject.org2023-11-29T15:55:56Zurn:sha1:cea4c505d8088f91cbe6b2884a9d54acafd80081
An encoded set of extensions in the ntorv3 handshake includes a header
with the number of extensions. This change adds that header.
It also changes `write_many_onto` to take a slice instead of an
iterator, since we need to know the number of extensions up-front. In
principle we could take a clonable iterator instead and use
Iterator::count, but it's probably not worth the extra complexity.
Remove RngCompatExt.2023-11-29T15:55:04ZNick Mathewsonnickm@torproject.org2023-11-29T15:49:26Zurn:sha1:7fb24cb69da537ac04ab2dae80997c6d481622ef
This code was needed with the old version of dalek-cryptography,
which wasn't compatible with up-to-date versions of the `rand`
crate(s). But now that we've upgraded, we can drop this.
(We could have left it around and deprecated it, but we are already
making a breaking change to tor-llcrypto by upgrading
dalek-cryptography.)
Convert to the latest versions of dalek-cryptography2023-11-29T15:34:58ZNick Mathewsonnickm@torproject.org2023-11-21T15:58:29Zurn:sha1:98037a2c788bd901679139178d25f855324637f3
The main changes that we have to adjust for are as follows:
* In x25519-dalek:
* `StaticSecret` is now behind a feature.
* `StaticSecret::new` is deprecated in favor of
`StaticSecret::random_from_rng`.
* StaticSecret no longer does its own clamping.
* In ed25519-dalek:
* `SecretKey` has (in effect) been renamed to `SigningKey`. The name
`SecretKey` is now an alias for `[u8; 32]`.
* `SigningKey` is effectively a keypair, since it contains a
public key as well.
* `PublicKey` has been renamed to `VerifyingKey`.
* The functions to extract a signing key and verifying key have
been renamed as you might expect.
* `ExpandedSecretKey` has been moved to `hasmat` and no longer
implements `sign`.
* `ExpanededSecretKey` now has as its elements a scalar and a hash
prefix.
* Various functions that took `&[u8]` now take `&[u8; N]`.
* We no longer need a wrapper for older versions of rand.
There is a single test in tor-keymgr that does not pass. I've
marked it as ignore for now, in hopes that @gabi-250 can help me
figure it out.
This closes #808. There are several changes I want to make before
we merge, however. They are marked with TODO DALEK.
Add NtorV3SecretKey::generate_for_test and NtorV3SecretKey::new2023-11-27T16:48:04ZJim Newsomejnewsome@torproject.org2023-11-01T21:28:09Zurn:sha1:02e951d4f53cbb7e3b4ce6d58df3cb2fc374cd93