mirrors/arti.git/crates/tor-proto/src/crypto/cell.rs, branch arti-v1.4.5mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.52025-05-22T09:05:31Zproto: remove bench pub wrappers2025-05-22T09:05:31ZLionel Goffauxlionel.goffaux@unamur.be2025-05-22T09:05:31Zurn:sha1:e5653df87971650d356dc9fa7e0e3570df44d504proto: extend benchmarks2025-05-08T09:34:11ZLionel Goffauxlionel.goffaux@unamur.be2025-05-08T09:34:11Zurn:sha1:d11b1556751c9e10850c9cad7c1f52aaeb2debecproto: Apply type-specific wrappers for tor1 crypto2025-05-06T22:34:17ZNick Mathewsonnickm@torproject.org2025-04-30T11:59:47Zurn:sha1:efcca717bd3b90fa29bb0421eeb936f247671549
Now instead of using CryptState for everything, we have specific
types for each role and direction of crypto.
This turned up a harmless-so-far bug in our onion service code: as
an onion service, we were using _client_ crypto layers to respond to
a client request. That's not correct, and wouldn't have worked
with CGO. Instead, we need to use relay crypto layers, wrapped
as client layers.
Closes #1975.
proto, cell: Remove RelayCellFormatTrait.2025-05-06T22:34:17ZNick Mathewsonnickm@torproject.org2025-04-30T00:59:07Zurn:sha1:297aa8027f7528605fe5bf2097f3474d9ba3eef9
The purpose of the trait was to parameterize the tor1 cell crypto
on the different possible relay cell layouts.
It made sense to have this trait when we thought we would implement
the new cell layout for prop340 (packed-and-fragmented) well before
we implemented CGO.
But it now appears all but certain that CGO will land long before
we make any more headway on prop340. Therefore,
it doesn't make sense to carry the ability to customize `tor1`
for other relay cell layouts.
Removing this trait saves a fair bit of complexity.
Emit SendmeTag directly from cell crypto.2025-05-06T22:34:17ZNick Mathewsonnickm@torproject.org2025-04-30T00:26:15Zurn:sha1:a50692cd37f5e35182b823c67defc5e6cd8810be
This changes the code to copy a SendmeTag rather than returning a
slice. This isn't actually a big change: sending a slice already
required 16 bytes (on 64-bit platforms), so sending a SendmeTag
around isn't a big deal.
We rely extensively on the compiler's ability to optimize away
all the checking in code like this:
```
let slice: &[u8];
let a: [u8;N] = slice[0..N].try_into().expect("Nope");
```
I've spot-checked it somewhat with "cargo-show-asm", but
it could use more thorough checking.
Closes #1956.
proto: Split out CGO BlkCipher trait for Encryption/Decryption2025-05-06T22:34:17ZNick Mathewsonnickm@torproject.org2025-04-29T21:19:51Zurn:sha1:de696fdaf992f2ab92b886b2d42b7eae86b58836
This lets us use `Aes128Dec` and `Aes128Enc` in place of plain old
`Aes128`, which can be less space-efficient depending on the
back-end.
tor-proto: use RelayCellFormat rather than u8 in tests.2025-04-29T16:35:21ZNick Mathewsonnickm@torproject.org2025-04-24T13:55:04Zurn:sha1:ffdacdb41f89583eb1f6af3b37cbdf81227efe48
(The u8 code was written before RelayCellFormat::V1 was introduced.)
Rename feature cgo => counter-galois-onion.2025-04-29T16:35:19ZNick Mathewsonnickm@torproject.org2025-04-24T13:49:40Zurn:sha1:65974c8ab586c6d3b92374071ab0c1e4950c3c99proto: Implement and test CGO cryptography.2025-04-29T16:35:04ZNick Mathewsonnickm@torproject.org2025-04-15T00:57:32Zurn:sha1:37aba22d180e5817bcb3302e8fb4e55494a382fc
This provides all the operations from proposal 359,
along with the necessary integration and unit tests to make sure
that they are behaving properly.
Closes #1943
proto: Unified integration tests for relay crypto.2025-04-29T16:31:09ZNick Mathewsonnickm@torproject.org2025-04-15T16:15:40Zurn:sha1:00ef5678255d5f37e96336bc7fa5385166420e60