mirrors/arti.git/crates/tor-proto/src/crypto/cell.rs, branch arti-v1.1.13mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.132024-01-02T15:04:18Zclippy: consequential rustfmt2024-01-02T15:04:18ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-02T12:49:55Zurn:sha1:1ba7e8a78f21b5e1c26c87d12e7a77ebb3a8949dclippy: Use infallible calls2024-01-02T13:56:22ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-02T12:48:56Zurn:sha1:0ce386a24bd5b0490aee28345f90c7ac956a844d
Resolves clippy complaints about needless fallible conversions.
tor-proto: Refactor the key derivation2023-09-29T06:09:05ZEmil Englerme@emilengler.com2023-09-29T06:09:05Zurn:sha1:295c565944da864925daad3cfab12de010e97690
This commit refactors the key derivation, by applying the following:
- The spaghetti slice creation with the hard-to-read boundaries got
replaced by a closure, which accepts a length, advances the seed slice
by n bytes as a side-effect, and returns the just advanced bytes
- The use of `.except` got replaced by an `.or`, with the use of the
already existing `InvalidKDFOutputLength` error, thereby removing a
potential panic (probably not reachable in runtime though)
- The conversion from a slice to a `CircuitBinding` got moved into a
`TryFrom` trait of the appropriate data structure
Merge branch 'misc-upgrades' into 'main'2023-09-28T15:35:00ZNick Mathewsonnickm@torproject.org2023-09-28T15:35:00Zurn:sha1:f6135ebf903a2210b7023d01923641fece4350be
Upgrade several dependencies
See merge request tpo/core/arti!1626tor-proto: Replace repeating pattern with fill2023-09-28T15:00:44ZEmil Englerme@emilengler.com2023-09-28T15:00:44Zurn:sha1:9224d55e9956c13da6386bbb8a13f1373f4c69a3
This commit replaces a repeating code pattern in the `set_digest`
function for setting the 'Recognized' and Digest field to zero with a
slice fillment.
Besides this, it also adds comments explaining which fields are
currently getting zeroized.
Remove direct dependency on generic-array2023-09-28T14:59:29ZNick Mathewsonnickm@torproject.org2023-09-28T14:15:47Zurn:sha1:34766342614bb4ca5742ee041273e99ff690ed20
Instead of tying ourselves to a particular version of the
generic-array crate, we now always use the version re-exported by
our RustCrypto crates. This lets us avoid the possibility of
version mismatch.
(Originally I had planned to upgrade to generic-array 1.0, but then
I found that we were not actually using it.)
tor-proto: Remove the Display impl of HopNum.2023-08-25T13:57:21ZGabriela Moldovangabi@torproject.org2023-08-25T13:33:24Zurn:sha1:6bc83ccc5754ac86f1ca1fcebf09dddcdd63c2b1
This removes the `Display` impl of `HopNum` and replaces its usage with
`HopNum::display`.
tor-proto: Add a HopNum::display function.2023-08-25T13:57:14ZGabriela Moldovangabi@torproject.org2023-08-25T13:18:58Zurn:sha1:12a7ff445190f3af2ab82c240469595e7a50c3c6
This function can be used to display a more user-friendly representation
of a `HopNum`. This will print hop numbers as 1-indexed values: #1,
#2, etc..
We will soon remove HopNum's Display implementation in favour of
`.display()`.
tor-proto: Make HopNum indices appear 1-based in the Display impl.2023-08-25T10:39:25ZGabriela Moldovangabi@torproject.org2023-08-25T10:20:19Zurn:sha1:fa1d15560fa434de4b36029dd67916471eb9b83c
This makes `HopNum`s display as 1-indexed values. This will make error
messages more intuitive, because when talking about an N-hop circuit, we
generally speak in terms of hops 1..N (rather than 0..N-1).
Internally, our `HopNum` indices are still 0-based.
Closes #996
Run maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac