mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=main 2023-09-29T06:09:05Z 2023-09-29T06:09:05Z Emil Engler me@emilengler.com 2023-09-29T06:09:05Z urn:sha1:295c565944da864925daad3cfab12de010e97690 This commit refactors the key derivation, by applying the following: - The spaghetti slice creation with the hard-to-read boundaries got replaced by a closure, which accepts a length, advances the seed slice by n bytes as a side-effect, and returns the just advanced bytes - The use of `.except` got replaced by an `.or`, with the use of the already existing `InvalidKDFOutputLength` error, thereby removing a potential panic (probably not reachable in runtime though) - The conversion from a slice to a `CircuitBinding` got moved into a `TryFrom` trait of the appropriate data structure 2023-09-13T16:28:27Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-13T16:08:31Z urn:sha1:cfbe03f59bc8ab80312d63b3e7aa98fbdb55e467 Fixes cargo clippy -p tor-hsclient --all-features --all-targets 2023-08-14T17:15:29Z Nick Mathewson nickm@torproject.org 2023-08-04T12:51:26Z urn:sha1:65a0ac5512f7a147e58c64faacc9cb87cb0e4ecf Closes #993 2023-08-14T17:15:29Z Nick Mathewson nickm@torproject.org 2023-08-03T21:15:51Z urn:sha1:0ffa6eddf5c6ad6542102a4d28b287e744a38aeb These values are computed as part of the circuit extension handshake, and are used as MAC keys to bind `ESTABLISH_INTRO` messages to a particular circuit so that they can't be replayed. Part of #993.