mirrors/arti.git/crates/tor-proto/src/congestion, branch arti-v1.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.5.02025-08-11T15:22:24Zclippy: fix `clippy::duplicated_attributes` warnings2025-08-11T15:22:24ZSteven Engleropara@torproject.org2025-08-11T15:22:22Zurn:sha1:327f6a31c0fed9ff0b17ac2257157274fbe6d4cb
```text
warning: duplicated attribute
--> crates/tor-hsservice/src/timeout_track.rs:630:14
|
630 | #![allow(clippy::needless_pass_by_value)] // TODO hoist into standard lint block
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
Rename and invert the sense of requires_stream_level_sendmes.2025-07-23T14:59:51ZNick Mathewsonnickm@torproject.org2025-07-14T15:37:00Zurn:sha1:d4025dff2f2fecb717099a56bacb2a9b497b110d
Instead call it compatible_with_cgo, which is what we actually
care about in this context.
proto: Send extensions as appropriate to negotiate CGO.2025-07-23T14:59:51ZNick Mathewsonnickm@torproject.org2025-06-11T12:19:28Zurn:sha1:3591c05e34336a210fcae8cb4c69e149c3f88e42
Let's see if it works!
tor-proto: add `CongestionControl::uses_xon_xoff()`2025-07-16T17:36:43ZSteven Engleropara@torproject.org2025-07-15T04:39:32Zurn:sha1:54ea2fc30d7cef2d4b313827451d5f7bf399cc2fproto: Make RttEstimator::{ewma,min}_rtt_usec() return `Option`.2025-06-27T14:16:16ZGabriela Moldovangabi@torproject.org2025-06-25T18:58:50Zurn:sha1:1e4a9161e78b78aadbe777cd5e4991a2582c8918
A `None` value signals to the conflux code to know to fall back on the
initial RTT of the circuit.
Without this change, the conflux switching logic is broken as we end up
staying on the leg with the best initial RTT forever (the other leg is
never picked, because its `ewma_rtt()` is stuck on `u32::MAX`, and never
updated as we never send on it).
proto: Rewrite can_crosscheck_with_current_estimate for clarity.2025-06-25T16:21:46ZGabriela Moldovangabi@torproject.org2025-06-25T16:04:32Zurn:sha1:65d565ccfe7880ab0e3b6ba70c1f822ace224246
The expanded expression makes it easier to see that
`can_crosscheck_with_current_estimate()` can never return `true` if
`self.ewma_rtt` is `None`, and that the `expect()` from
`is_clock_stalled()` cannot panic.
proto: Make RTT estimates default to None (fmt).2025-06-25T16:21:46ZGabriela Moldovangabi@torproject.org2025-06-25T16:03:59Zurn:sha1:2c061d5589858a73539a1a078f993071103574a5proto: Make RTT estimates default to None.2025-06-25T16:21:46ZGabriela Moldovangabi@torproject.org2025-06-25T15:43:45Zurn:sha1:1a901b349a53b3a625b76af923324da90a39a82b
The `RttEstimator` now uses `None` to represent not-yet-measured RTTs.
Previously, all the measured RTTs defaulted to 0, in contradiction with
the `RttEstimator::{min,ewma}_rtt_usec()` docs, which state that both
functions are supposed to return `u32::MAX` if there is no estimate.
Closes #2049
tor-proto: Add an accessor for the cc algorithm.2025-06-11T18:02:47ZGabriela Moldovangabi@torproject.org2025-03-21T18:27:39Zurn:sha1:3637434be521fd83849fa836e781a198419f8bb6
Conflux is only supported when prop324 congestion control is enabled, so
we need an accessor for the cc algorithm of a given circuit hop in order
for the conflux code to be able to check *which* cc algorithm is in use.