mirrors/arti.git/crates/tor-proto/src/congestion/rtt.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
tor-proto: rtt: return clock stall/jump status from `update()`2026-05-07T19:06:39ZSteven Engleropara@torproject.org2026-05-07T19:05:01Zurn:sha1:8d90606eaee9dc6d749958ff8e54ca3b172ab8e6tor-proto: Port to web-time-compat2026-03-26T19:20:16ZNick Mathewsonnickm@torproject.org2026-03-26T14:33:04Zurn:sha1:11f365738ade6ba75eedee83d7d19f8877da7d65Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
proto: Add an accessor for the max observed circ RTT.2025-09-16T14:10:33ZGabriela Moldovangabi@torproject.org2025-09-10T15:57:19Zurn:sha1:dc1ebe51e1de3476c037c1c0e46de466ff4edbd9
We will need this to calculate the END ack timeout.
clippy: fix `clippy::duplicated_attributes` warnings2025-08-11T15:22:24ZSteven Engleropara@torproject.org2025-08-11T15:22:22Zurn:sha1:327f6a31c0fed9ff0b17ac2257157274fbe6d4cb
```text
warning: duplicated attribute
--> crates/tor-hsservice/src/timeout_track.rs:630:14
|
630 | #![allow(clippy::needless_pass_by_value)] // TODO hoist into standard lint block
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
proto: Make RttEstimator::{ewma,min}_rtt_usec() return `Option`.2025-06-27T14:16:16ZGabriela Moldovangabi@torproject.org2025-06-25T18:58:50Zurn:sha1:1e4a9161e78b78aadbe777cd5e4991a2582c8918
A `None` value signals to the conflux code to know to fall back on the
initial RTT of the circuit.
Without this change, the conflux switching logic is broken as we end up
staying on the leg with the best initial RTT forever (the other leg is
never picked, because its `ewma_rtt()` is stuck on `u32::MAX`, and never
updated as we never send on it).
proto: Rewrite can_crosscheck_with_current_estimate for clarity.2025-06-25T16:21:46ZGabriela Moldovangabi@torproject.org2025-06-25T16:04:32Zurn:sha1:65d565ccfe7880ab0e3b6ba70c1f822ace224246
The expanded expression makes it easier to see that
`can_crosscheck_with_current_estimate()` can never return `true` if
`self.ewma_rtt` is `None`, and that the `expect()` from
`is_clock_stalled()` cannot panic.
proto: Make RTT estimates default to None (fmt).2025-06-25T16:21:46ZGabriela Moldovangabi@torproject.org2025-06-25T16:03:59Zurn:sha1:2c061d5589858a73539a1a078f993071103574a5proto: Make RTT estimates default to None.2025-06-25T16:21:46ZGabriela Moldovangabi@torproject.org2025-06-25T15:43:45Zurn:sha1:1a901b349a53b3a625b76af923324da90a39a82b
The `RttEstimator` now uses `None` to represent not-yet-measured RTTs.
Previously, all the measured RTTs defaulted to 0, in contradiction with
the `RttEstimator::{min,ewma}_rtt_usec()` docs, which state that both
functions are supposed to return `u32::MAX` if there is no estimate.
Closes #2049