mirrors/arti.git/crates/tor-proto/src/congestion/rtt.rs, branch arti-v1.6.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.6.02025-09-16T14:10:33Zproto: Add an accessor for the max observed circ RTT.2025-09-16T14:10:33ZGabriela Moldovangabi@torproject.org2025-09-10T15:57:19Zurn:sha1:dc1ebe51e1de3476c037c1c0e46de466ff4edbd9
We will need this to calculate the END ack timeout.
clippy: fix `clippy::duplicated_attributes` warnings2025-08-11T15:22:24ZSteven Engleropara@torproject.org2025-08-11T15:22:22Zurn:sha1:327f6a31c0fed9ff0b17ac2257157274fbe6d4cb
```text
warning: duplicated attribute
--> crates/tor-hsservice/src/timeout_track.rs:630:14
|
630 | #![allow(clippy::needless_pass_by_value)] // TODO hoist into standard lint block
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
proto: Make RttEstimator::{ewma,min}_rtt_usec() return `Option`.2025-06-27T14:16:16ZGabriela Moldovangabi@torproject.org2025-06-25T18:58:50Zurn:sha1:1e4a9161e78b78aadbe777cd5e4991a2582c8918
A `None` value signals to the conflux code to know to fall back on the
initial RTT of the circuit.
Without this change, the conflux switching logic is broken as we end up
staying on the leg with the best initial RTT forever (the other leg is
never picked, because its `ewma_rtt()` is stuck on `u32::MAX`, and never
updated as we never send on it).
proto: Rewrite can_crosscheck_with_current_estimate for clarity.2025-06-25T16:21:46ZGabriela Moldovangabi@torproject.org2025-06-25T16:04:32Zurn:sha1:65d565ccfe7880ab0e3b6ba70c1f822ace224246
The expanded expression makes it easier to see that
`can_crosscheck_with_current_estimate()` can never return `true` if
`self.ewma_rtt` is `None`, and that the `expect()` from
`is_clock_stalled()` cannot panic.
proto: Make RTT estimates default to None (fmt).2025-06-25T16:21:46ZGabriela Moldovangabi@torproject.org2025-06-25T16:03:59Zurn:sha1:2c061d5589858a73539a1a078f993071103574a5proto: Make RTT estimates default to None.2025-06-25T16:21:46ZGabriela Moldovangabi@torproject.org2025-06-25T15:43:45Zurn:sha1:1a901b349a53b3a625b76af923324da90a39a82b
The `RttEstimator` now uses `None` to represent not-yet-measured RTTs.
Previously, all the measured RTTs defaulted to 0, in contradiction with
the `RttEstimator::{min,ewma}_rtt_usec()` docs, which state that both
functions are supposed to return `u32::MAX` if there is no estimate.
Closes #2049
fix: fix typos2025-01-30T08:39:30ZDimitris Apostoloudimitris.apostolou@icloud.com2025-01-30T08:39:30Zurn:sha1:6371829c976f6a5b77d46bf977f369a915f2ced3congestion: Use getters for all parameters2025-01-16T14:16:01ZDavid Gouletdgoulet@torproject.org2025-01-15T15:29:46Zurn:sha1:2fd9a4d5b814b3a0aa031313d081f0d306016908
Allows us to remove the pub.
Signed-off-by: David Goulet <dgoulet@torproject.org>
congestion: Add standard clippy checks to tests2025-01-16T14:16:01ZDavid Gouletdgoulet@torproject.org2025-01-08T19:04:07Zurn:sha1:69d4df8eca23637f68d1e83027dc4f3ebcc52a43
Signed-off-by: David Goulet <dgoulet@torproject.org>
congestion: Make a test_utils.rs2025-01-16T14:16:01ZDavid Gouletdgoulet@torproject.org2025-01-08T15:50:46Zurn:sha1:6a1ee397fad1a5936e1f90d2c2c0744f8a0536fd
Instead of having the congestion.rs test module public, make a
test_utils.rs file that contains code for other unit tests within the
congestion module.
Signed-off-by: David Goulet <dgoulet@torproject.org>