mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.4.0 2026-05-28T14:58:35Z 2026-05-28T14:58:35Z Gabriela Moldovan gabi@torproject.org 2026-05-28T14:57:15Z urn:sha1:642d0ffa22d20e3eec5f2996d33f697e91e982a9 `RawCellStream` was removed long ago, in c559754116678866eabe525f5b189b50cc78b5cc. 2026-05-21T16:35:59Z Steven Engler opara@torproject.org 2026-05-21T15:13:07Z urn:sha1:3ae295c879f773b8c6e922436fb96c020777555a 2026-05-21T16:35:59Z Steven Engler opara@torproject.org 2026-05-21T02:13:21Z urn:sha1:73088207825942721ec02ccec4d2424e688586f3 This better matches nearby code. 2026-05-21T16:35:59Z Steven Engler opara@torproject.org 2026-05-21T02:56:49Z urn:sha1:6a9e07f8d42ebd6f698b0def041c5424cf2d42b8 2026-05-21T16:35:59Z Steven Engler opara@torproject.org 2026-05-21T01:57:13Z urn:sha1:e62d824614fc501d21f6b58f1e98346bf495e1e3 Previously when initializing a stream, we constructed most of the stream-related queues outside of the reactor and passed the relevant halves of the queues (senders or receivers) into the reactor. A downside of the above approach is that the reactor may be better informed about what queues to construct, and how to construct them. For example the reactor knows what type of flow control that the hop is using, so it knows whether we need queues for passing rate limits and drain rates for XON/XOFF flow control. This commit moves the construction of these queues into the reactor and passes the relevant halves out of the reactor. In the future we can make better decisions about which queues are needed depending on the flow control method used instead of always constructing them (see arti#2068). Reviewing with `--color-moved` might be helpful as a few lines have been moved. 2026-05-21T01:52:49Z Steven Engler opara@torproject.org 2026-05-20T19:29:58Z urn:sha1:2801a1b30f50488ca79bbe21d3061b07fe40b945 2026-05-21T00:36:59Z Steven Engler opara@torproject.org 2026-05-12T22:36:57Z urn:sha1:be505ab176da88dd8cea7e3a42530d81fb0267b5 The stream queue length (for messages incoming from the Tor network) depends on the type of flow control we're using for the hop. Currently we construct the stream queue outside of the circuit reactor, but we don't have the flow control information here. Instead of constructing the stream queue outside of the reactor and passing the sender into the reactor, we construct the stream queue inside of the reactor and pass the receiver out of the reactor. 2026-05-12T20:55:43Z Wesley Aptekar-Cassels me@wesleyac.com 2026-05-07T20:06:21Z urn:sha1:a18167928901d8c88cd1cdd87346de8ad1ee42a2 When the circ-padding feature is enabled, we use maybenot, which does not yet support rand 0.10. In the meantime, enabling this feature pulls in rand 0.9. This is not ideal, but should be okay as a temporary situation. This also replaces the use of ReseedingRng (which was removed in 0.10) with the reseeding_rng crate. This is somewhat less performant, but it should be okay. 2026-05-11T21:06:25Z Steven Engler opara@torproject.org 2026-05-11T20:40:46Z urn:sha1:2719019310d76aafebe6b33b01512d09a55eeae3 2026-05-11T20:44:42Z Steven Engler opara@torproject.org 2026-05-11T20:37:48Z urn:sha1:d9bdf01549feefb4d9114a6c47b3d6bde25b14c0