mirrors/arti.git/crates/tor-proto/src/client/reactor.rs, branch arti-v1.6.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.6.02025-10-01T02:55:15Ztor-proto: fix comment related to validating stream messages2025-10-01T02:55:15ZSteven Engleropara@torproject.org2025-10-01T02:55:04Zurn:sha1:c50199fb3b4c0bb9e0c4644bf6617cf7f63dd044
I don't think the previous comment is correct. The main flow control
checks are about receiving SENDME/XON/XOFFs, and ensuring that we don't
receive too many of them. This all happens in the reactor.
In theory the stream should be checking that we don't receive too many
DATA messages for how many stream SENDMEs we've sent. But this is broken
due to arti#2100. We do check this in the halfstream code though.
Sort output events for next_circ_action.2025-09-29T17:00:49ZNick Mathewsonnickm@torproject.org2025-09-29T15:27:29Zurn:sha1:ff1c086eca6f561bbc19a64afdfef317bbc19540
This sort makes it so that that blocking and unblocking are always
ordered in a sensible way with respect to sending data. This might
help simplify padding machines a bit.
Prerequisite for #2190
proto: Rewrite ConfluxSet::next_circ_action() using PollAll.2025-09-25T13:40:00ZGabriela Moldovangabi@torproject.org2025-09-18T17:25:58Zurn:sha1:e93ae49e442d9aa9f14a1ca52b36f3553aa44c1f
This removes our usage of `FuturesUnordered` in
`ConfluxSet::next_circ_action()` to address two issues:
* a fairness issue, where the futures driven by `FuturesUnordered`
could be starved under some circumstances (#2180)
* a logic error, where we'd explicitly avoid reading from the input
channel if the outgoing `chan_sender` channel was blocked (#2179)
Note that the fixing the latter will cause the reactor to buffer more
into the unbounded `chan_sender` sink, but that *should* be okay,
because no input message should be able cause us to queue cells
excessively.
Closes #2179, #2180
proto: Return multiple actions from next_circ_action (fmt).2025-09-25T13:37:41ZGabriela Moldovangabi@torproject.org2025-09-18T17:12:10Zurn:sha1:e8f0ab9613f70548bf6153d14d714848c16d9fc2proto: Return multiple actions from next_circ_action.2025-09-25T13:37:41ZGabriela Moldovangabi@torproject.org2025-09-18T16:59:52Zurn:sha1:f2ab08eda241b15b5b3efb0f422ec79012cc54dc
Part of #2180
Note: the code is intentionaly left misindented to make reviewing a
bit easier. A future commit will fix the indentation.
Merge branch 'expire-halfstream-cbt' into 'main'2025-09-24T18:08:19Zgabi-250gabi@torproject.org2025-09-24T18:08:19Zurn:sha1:276b8a5820f55eb2f0e09f424e22f794b111fcf1
proto: Remove half-streams when they expire.
Closes #264
See merge request tpo/core/arti!3267proto: Temporarily ignore large_enum_variant clippy warning.2025-09-23T09:50:23ZGabriela Moldovangabi@torproject.org2025-09-23T09:50:23Zurn:sha1:e83461f8bf02579753f351d26a578010809b31fb
I want to tackle this separately, as part of #2003
proto: Add new error type for cells received on non-existent streams.2025-09-22T15:25:45ZGabriela Moldovangabi@torproject.org2025-09-22T14:40:29Zurn:sha1:cb72b6403f1fff16ae590777119399e1c48972c4
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/3267#note_3261239
proto: Log circuit reactor errors at debug level.2025-09-22T14:11:44ZGabriela Moldovangabi@torproject.org2025-09-22T14:11:44Zurn:sha1:e8a94490d8fa7611c11bcf34fdbd98fc6350db00proto: Calculate CBT more accurately.2025-09-19T10:00:36ZGabriela Moldovangabi@torproject.org2025-09-19T10:00:36Zurn:sha1:c6e944a9de91905c273d582c7f1de045d1eb2e41
This should look at length of the circuit up until the hop where the
half-stream is (because the half-stream might be on an intermediate hop,
and not necessarily on the final one).