mirrors/arti.git/crates/tor-proto/src/circuit, branch arti-v1.2.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.0 2024-02-27T16:57:25Z tor-circmgr: Add a helper for displaying optional UniqIds. 2024-02-27T16:57:25Z Gabriela Moldovan gabi@torproject.org 2024-02-27T15:06:48Z urn:sha1:62923a6758be629b684d67237f7d7207abad33f0 Some of the `tor_circmgr::Error` variants will include the `UniqId` of the corresponding circuit, so we'll need to be able to display it without the `Circ ` prefix. Part of #1297 proto: Use log_ratelim to report problems delivering BEGIN messges. 2024-01-17T14:25:56Z Nick Mathewson nickm@torproject.org 2024-01-17T14:25:56Z urn:sha1:c5478deab5b8bb4a1ea55946483bad948ff9eca0 Give an error on duplicate call to allow_stream_requests. 2024-01-17T14:00:34Z Nick Mathewson nickm@torproject.org 2024-01-17T14:00:34Z urn:sha1:8bff4734d70bc1260cfd5fdfb230e479b79065fc Closes #1190 proto: Close circuit _intentionally_ when Request Sink is dropped. 2024-01-17T13:45:54Z Nick Mathewson nickm@torproject.org 2024-01-17T13:45:54Z urn:sha1:163aec238f5cba8434826130d5637f6ae3a24a4b In theory, it might be better to just un-register the IncomingStreamRequestHandler when the Receiver for the stream requests is dropped. However, there are two reasons not to do so: 1. It's tricky. We never actually poll on the corresponding Sink, so there isn't a place where the Reactor would expect to get a prompt notification of closure. We only find out that the Receiver has been dropped when an attempt to send on the Sink returns an `is_disconnected` error. 2. It's unnecessary. In the Tor protocols, once we have decided to accept incoming stream requests on a circuit, we want to continue to do so until one of the parties closes the circuit. I've documented this in several comments, in case whe want to get fancier in the future. Closes #1188. proto: Send END when buffer of IncomingRequests is full 2024-01-17T13:16:48Z Nick Mathewson nickm@torproject.org 2024-01-17T13:16:48Z urn:sha1:428285a3b9df515e25a4b4265950b3a0fc788430 Closes #1189. Convert a TODO HSS about excessive BEGINs to #1189. 2024-01-10T14:53:51Z Nick Mathewson nickm@torproject.org 2024-01-10T14:53:51Z urn:sha1:862d041e2adfe633d182d97c1bf321b2af1e2f00 proto: Downgrade TODO HSS about HopNum in IncomingStreamRequestComment 2024-01-10T14:29:53Z Nick Mathewson nickm@torproject.org 2024-01-10T14:24:28Z urn:sha1:64f78cf1fea5a81578d618d20d5689ad44d89e06 These comments are about internal representations and future extensions. Also, add a fail-safe check to make sure that hop_num consistency is enforced. proto: Downgrade TODO HSS comments about hop lookup 2024-01-10T14:19:42Z Nick Mathewson nickm@torproject.org 2024-01-10T14:19:42Z urn:sha1:a7f9f481f488e8be60808332b0a07e325f11505e proto: Change some TODO HSS comments to refer to #1188 2024-01-10T14:18:19Z Nick Mathewson nickm@torproject.org 2024-01-10T14:18:19Z urn:sha1:928bd6829347ebd6cc1075fee5364e1b9b859a5f clippy nightly: For now, locally allow blocks_in_conditions 2024-01-02T15:04:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-02T14:51:30Z urn:sha1:2e459400ebc4cb40622cf2eb42803afafbc05ad4 Filed https://gitlab.torproject.org/tpo/core/arti/-/issues/1176 proposing a final fix.