mirrors/arti.git/crates/tor-proto/src/circuit, branch arti-v1.1.10

Add a caret_int HandshakeType for HTYPE constants

2023-10-26T15:14:40Z

Change `CircId` to never be zero

2023-10-25T20:35:12Z

This changes the internal representation to be `NonZeroU32` instead of just `u32`. Various places where a circuit ID is optional now use `Option`. Fixes a bug in `CircIdRange::sample` that would previously return a circuit ID of 0, when the rng returned 0x8000_0000 for a low range.

Convert StreamId to NonZeroU16

2023-10-25T20:34:55Z

proto: Revise the behavior of IncomingStream::discard().

2023-10-19T17:15:10Z

Because dropping a `StreamTarget` causes the circuit reactor to send an End, the previous do-nothing implementation of `discard()` wasn't sufficient to cause the request to be ignored without sending an End. This commit modifies our "close pending stream" behavior to only optionally send an End message. To avoid confusion, I'm using a new `CloseStreamBehavior` enum rather than an `Option`, since we had previously used `None` in some cases to indicate a default (misc) end message.

proto: Remove TODOs about panics on double-close.

2023-10-19T17:15:10Z

Now that `StreamMap::terminate` no longer panics, and now that it permits the kind of double-call that we allow, we can close #1065. Closes #1065.

proto: Have EndSent remember if we have dropped the stream target.

2023-10-19T17:15:10Z

The rule is that we allow up to one explicit `close_pending`, followed by exactly one final `mpsc::Sender` drop.

proto: Give StreamMap::terminate a "why" argument

2023-10-19T17:15:10Z

We will use this to enforce correct ordering on "close" vs "drop" APIs.

Add comments about another problem with close_pending().

2023-10-17T13:04:24Z

See #1065 for more information here.

proto: Remove a TODO about merging two functions.

2023-10-12T13:04:33Z

There is some similarity, but there's not really a logical way to combine the two that actually results in less, clearer code.

Lower and downgrade a TODO about StreamID and NonZeroU16.

2023-10-12T12:58:28Z