mirrors/arti.git/crates/tor-proto/src/circuit, branch arti-v0.0.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.42022-01-19T18:46:13Zclippy: Rename a `decode_chanmsg` from `handle_`2022-01-19T18:46:13ZIan Jacksonijackson@chiark.greenend.org.uk2022-01-19T18:45:20Zurn:sha1:9a77b23cddee1ed378ac0af8c2b248c3880bc069
As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771025
It doens't really handle it.
clippy: Rename a `from_foo` method that doesn't do conversion2022-01-19T17:26:09ZIan Jacksonijackson@chiark.greenend.org.uk2022-01-19T17:20:35Zurn:sha1:c4338999488cd332544c6d91cee6b42a36ebe569Describe when we will need SendmeAcceptMinVersion2022-01-12T20:52:24ZNick Mathewsonnickm@torproject.org2022-01-12T20:52:24Zurn:sha1:bbf7c59b2dc7ed8aeaf3604beeb619961874610c
(spoiler: not until we have a relay implementation)
Closes #53.
Change RequireSendmeAuth to an enum.2022-01-12T20:46:36ZNick Mathewsonnickm@torproject.org2022-01-12T20:46:36Zurn:sha1:e335f6c75aca2a39244390bd5f3c8ca66b2071d4
This is a fine example of why booleans are risky:
it's far to easy to pass "animate:bool" into "inanimate:bool" like
we did here.
This is a followup from our fix to #294.
Fix a boolean inversion in auth_sendme_optional.2022-01-12T20:36:55ZNick Mathewsonnickm@torproject.org2022-01-12T20:32:16Zurn:sha1:1e915c39465d616d71e57331d89e02235f156a31
Previously we were requiring authenticated sendme cells exactly when we
should be permitting the old format, and vice versa.
This bug was caused by using a boolean to represent one property, but
with giving that boolean two different senses without inverting at the
right time.
The next commit will prevent a recurrence.
Closes #294
Document SendmeEmitMinVersion status2022-01-12T20:13:19ZNick Mathewsonnickm@torproject.org2022-01-12T20:13:19Zurn:sha1:d49a490d4a3780b6c4a19b3cbebe7cd11091e016
(We don't need to look at SendmeEmitMinVersion since higher
values are not yet defined.)
tor-proto: Allow one meta-cell handler at a time.2021-12-16T21:01:50ZNick Mathewsonnickm@torproject.org2021-12-16T21:01:50Zurn:sha1:64257a10fae8d062a20c6fcc0c7c7787390e6e13
Previously the code would let us try to install a meta-cell handler
before the old one was done, leading to possible confusion.
Merge branch 'ct_sendme_tags' into 'main'2021-12-16T20:29:01Zetator@eta.st2021-12-16T20:29:01Zurn:sha1:6a12f388f288dc7b9ea82d9e9952d98c19be6402
tor-proto: use const-time eq on sendme tags.
See merge request tpo/core/arti!201tor-proto: set HalfStream::connected_ok right.2021-12-16T16:48:39ZNick Mathewsonnickm@torproject.org2021-12-16T16:48:39Zurn:sha1:51c4ca73f265558df6ae0c6766a02b228b8404be
Previously we'd always set it to true, allowing one CONNECTED per
half-closed stream even if the stream had already received a
CONNECTED cell.
This resolves an XXXX.
tor-proto: replace a streammap XXXX with a ticket.2021-12-16T16:33:50ZNick Mathewsonnickm@torproject.org2021-12-16T16:33:50Zurn:sha1:a09fbc9f271ce6ec474126db4415f7515bfd2b13