mirrors/arti.git/crates/tor-proto/src/circuit/sendme.rs, branch arti-v1.1.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.1 2023-01-27T13:28:02Z Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks. impl Debug for DataStream (and its components) 2022-02-24T17:49:34Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-24T17:47:42Z urn:sha1:b56115a04fb0ebedae04a5302a04501b83b845a6 My proximate motivation is that tls-api wants its inner streams to be Debug. But in general, I agree with the Rust API Guidelines notion that almost everything should be Debug. I have gone for the "dump all the things" approach. A more nuanced approach would be possible too. Update tor-proto errors to latest API. 2022-02-15T14:57:03Z Nick Mathewson nickm@torproject.org 2022-02-15T14:57:03Z urn:sha1:6b611d6deae2e003ea81f459cd5e005c37ab50ce tor-proto: use InternalError for internal errors. 2022-02-15T14:41:11Z Nick Mathewson nickm@torproject.org 2022-02-11T20:20:50Z urn:sha1:f23f375e42ef3237f9bbb7b8bfee47ecc9ced4a1 Fix typos 2022-02-02T18:18:22Z Dimitris Apostolou dimitris.apostolou@icloud.com 2022-02-02T18:18:22Z urn:sha1:65263218510ee9375ed423b42fbf555e96eab275 tor-proto: use const-time eq on sendme tags. 2021-12-16T16:06:30Z Nick Mathewson nickm@torproject.org 2021-12-16T16:06:30Z urn:sha1:d794355b077cf9aa7399c54e650afaaf548cdea4 There's no known attack here, but it's best practice to always compare digests using a constant-time comparison operator. This resolves an XXXX comment. Always check whether stream-level SENDMEs are expected. 2021-12-14T17:11:48Z Nick Mathewson nickm@torproject.org 2021-12-13T21:01:27Z urn:sha1:d5c2361d3f631c68b3aa16915d60df07b6c211ac (It's a protocol violation to get a SENDME when our send window is already full.) This patch makes SendWindow::put return a Result, so that it's easier to do the right thing with it. Closes #261. Resolve roughly half of the XXXXs. 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231. tor-proto: Stop using async_test in halfstream.rs and sendme.rs 2021-11-15T17:12:53Z Nick Mathewson nickm@torproject.org 2021-11-15T17:12:53Z urn:sha1:787a99545872cc474a13d3961b647c1495b6631d Thanks to eta's refactoring, these tests no longer need to be async.