mirrors/arti.git/crates/tor-proto/src/circuit/reactor, branch arti-v1.4.0

tor-proto: Make ControlHandler::handler return non-optional result.

2025-02-06T13:33:05Z

The commands for which the function returned `Ok(None)` have been refactored into `CtrlCmd`, so we no longer need `handle()` to return an `Option`.

tor-proto: Turn some CtrlMsgs into CtrlCmds.

2025-02-06T13:33:05Z

All `CtrlMsg`s to which the reactor did not respond by sending a cell down the channel are now `CtrlCmd`s. Most of this is code motion, best reviewed with `--color-moved`.

tor-proto: Make shutdown a CtrlCmd.

2025-02-06T13:33:05Z

proto: Fix feature gated import

2025-02-04T16:08:43Z

Signed-off-by: David Goulet

proto: Move the begin cell handling into CircHop

2025-02-04T16:08:43Z

Move the BEGIN cell handling into CircHop following the previous commit that move more code into CircHop. Signed-off-by: David Goulet

proto: Remove ConversationInHandler

2025-02-04T16:08:43Z

It is unused but most importantly it allows any RELAY cell to be sent from anywhere in the code which is really not desirable because it is skipping congestion control. It also allows us to remove the `control_tx` from the reactor which is one less channel to track/understand/think about. This opens up the door to all sorts of problems especially side channel that can be exploited if we are not careful. We can always bring this back if we need it but for now, it is unused and allows us to remove the `CtrlMsg::SendRelayCell` control message. No code behavior change. Signed-off-by: David Goulet

proto: Introduce a reactor ControlHandler

2025-02-04T16:08:43Z

This object only mission is to handle a control message (CtrlMsg). It encapsulates a reference to the reactor and its lifetime is only the time it takes to handle the message. Main goal of this is to try to reduce reactor.rs size into logical containers. No code behavior change. Signed-off-by: David Goulet

tor-proto: Rewrite circuit reactor run_once() loop to use select! (fmt).

2025-01-29T14:40:27Z

tor-proto: Rewrite circuit reactor run_once() loop to use select!.

2025-01-29T14:34:58Z

This rewrites the circuit reactor main loop to use `select_biased!` to poll multiple futures simultaneously. The new `run_once()`, like the old, first waits for an initial `CtrlMsg::Create`. Then, it uses a `select_biased!` to poll the `chan_sender` sink and shutdown channel for readiness. When the channel sink is ready, we poll the `control` and `input` channels like before, as well as the new `ready_streams` `Stream` (`ready_streams` is a `futures::Stream` that replaces the previous `send_outbound()` function). Most of the implementation remains unchanged, except the `handle_input`, `handle_cell` and `handle_control` functions no longer send anything on the `chan_sender` channel. Instead, they may do some (synchronous) processing, and send instructions for the remaining work that needs to be done (for example, for writing the cell to the `chan_sender` channel). These instructions are handled at the end of `run_once()`, and are encoded in the `RunOnceCmdInner` enum. What this change does **not** do: * the control channel *still* bypasses congestion control. We could fix this by making the various reactor functions send the `RunOnceCmdInner` commands to `run_once()` via a channel (instead of returning them). This would enable the reactor to stop reading the commands (except for handle `Sendme`, which would be handled separately) if it's blocked on congestion control.

tor-proto: Use SendRelayCell within CtrlMsg::SendRelayCell.

2025-01-29T14:26:27Z