mirrors/arti.git/crates/tor-proto/src/circuit/reactor.rs, branch arti-v1.2.2 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.2 2024-04-25T15:24:24Z Circuit reactor: document some requirements and assumptions 2024-04-25T15:24:24Z Jim Newsome jnewsome@torproject.org 2024-04-16T19:10:30Z urn:sha1:14f0ee82d1f8ffbbbead3e72340d2c98f05a73fc There are some tricky bits here that implicitly assume particular behavior in other bits for correctness. Document these requirements and assumptions. Fixes arti#1373 Make filter conditional, to fix build with hs-service disabled. 2024-03-26T16:55:05Z Nick Mathewson nickm@torproject.org 2024-03-26T13:13:53Z urn:sha1:0f39aadd7e40bc8502d0fddd066ccc3a9f00163e Refactor and simplify ClientCircSyncView 2024-03-26T16:55:05Z Nick Mathewson nickm@torproject.org 2024-03-26T13:05:29Z urn:sha1:3f997375bbe65599f46d85be7104a5868b304455 With this patch, it holds only a reference to `&reactor.hops`, which greatly simplifies the reactor code's fight with the borrow checker. I've left some TODO comments about future directions here. Rename the old IncomingStreamRequestContext to StreamReqInfo. 2024-03-26T16:55:05Z Nick Mathewson nickm@torproject.org 2024-03-26T12:51:46Z urn:sha1:500f7c562d0b28f3047fc5cee7cce34ee077517c (Doing this to prevent us having two structs with the same name.) Add an IncomingStreamRequestFilter to check early properties 2024-03-26T16:55:05Z Nick Mathewson nickm@torproject.org 2024-03-20T15:39:05Z urn:sha1:25da33c91ccbd3ac266edf871925ee6a341d4729 Based on designs in #1124. Note that there is a TODO here about a hack I had to do to appease the borrow checker. Define a type for a synchronous (blocking) view of a circuit state. 2024-03-26T16:55:03Z Nick Mathewson nickm@torproject.org 2024-03-20T14:48:01Z urn:sha1:d8a1c0af0e656643f7066ef0c8079c50aa982ad3 We'll use this as an argument for the callback that checks stream requests to make sure they're permitted. proto: Prevent general state-transitions on StreamEnt 2024-03-26T16:54:30Z Nick Mathewson nickm@torproject.org 2024-03-20T14:28:41Z urn:sha1:62d749c1eb7730eeb025885c7d7f86a0ac8c333a We want to keep an accurate count of the number of open streams, so we have to stop exposing `&mut StreamEnt` outside of the streammap module. proto: Refactor circuit::streammap::StreamEnt 2024-03-26T16:54:06Z Nick Mathewson nickm@torproject.org 2024-03-20T14:16:02Z urn:sha1:3ccc523b89d5ed37e76d8c2be43872d9127b8596 This is the first part of a refactoring that will let us keep code from the outside of `streammap` from changing a stream from one state to another. And we need to do _that_ so that StreamMap can count how many open streams it has. Refactor the logic for constructing crypt layers. 2024-03-26T15:43:43Z Nick Mathewson nickm@torproject.org 2024-03-20T18:00:49Z urn:sha1:9be8d835556f8d703a88693dd11888b41b851791 The key insights here are: - That relay cell format and crypto protocols aren't orthogonal: Once we have GCO, it will require V1. - That we only need the actual functions for layer construction to be generic; we don't need to proliferate generic parameters everywhere. - That the circuit::handshake module already does most of what we want. Add and use RelayCellFormatTrait 2024-03-20T14:10:32Z Jim Newsome jnewsome@torproject.org 2024-03-19T00:30:12Z urn:sha1:8a91f277bbb9faa263a33d6b270f652a0da98068 This lets us paramaterize types and functions by a particular relay cell format. We use this e.g. to statically parameterize the cell crypto functions, thereby removing some run-time branching in the hot path.