mirrors/arti.git/crates/tor-proto/src/circuit/reactor.rs, branch arti-v1.1.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.42023-03-23T11:50:18Ztor-proto: Feature-conditionalise some enum variants2023-03-23T11:50:18ZIan Jacksonijackson@chiark.greenend.org.uk2023-03-22T12:11:59Zurn:sha1:b8345353474094bd8c6f4dd3f442e867ad0fc537
This avoids some dead code warnings when building without send-control-msg.
tor-proto: Split off send-control-msg feature2023-03-23T11:50:18ZIan Jacksonijackson@chiark.greenend.org.uk2023-03-22T12:06:59Zurn:sha1:93809cc5941e7ddaa5ac3f5691a986033a4a9244tor-proto: Make send_control_message wait for the reactor.2023-03-08T19:21:33ZNick Mathewsonnickm@torproject.org2023-03-08T15:19:56Zurn:sha1:9c4bdb8d8d4df4ac7aa494c2c1a50a484f2393e5
This way we don't need to worry about race conditions that happen if
the caller thinks that the handler is installed before it really is.
tor-proto: Implement functionality to send a message and accept replies2023-03-08T19:21:33ZNick Mathewsonnickm@torproject.org2023-03-03T17:11:34Zurn:sha1:bc83d1e1de6b1d0a0c5bec7cc2c6f3cf5db89d98
This new function combines "sending a message" and "accepting
replies in a stream" into a single call, so that there is no gap
between when the message is sent and the replies are available.
There are a number of compromises here, in order to avoid API
proliferation. I've tried to contain them as best I can.
See comments for additional design discussion.
tor-proto: Change semantics of MetaCellHandler2023-03-08T19:21:33ZNick Mathewsonnickm@torproject.org2023-03-03T13:49:46Zurn:sha1:094fdc0d8d06f72e12230fccc641d3169ff13114
Now, the MetaCellHandler is responsible for consuming the messages
it gets, and reporting status to whatever task is waiting for a
status message.
Additionally, the MetaCellHandler can decide to remain installed or
shut down the circuit after a successful message. (Previously, it
could only uninstall itself on success and kill the circuit on
failure.)
These changes will enable MetaCellHandlers to be used as the basis
for handling more kinds of message.
(There is some moved and reformatted code here; you may want to
review it with `git {diff or show} --color-moved -b`.)
tor-proto: Give circ Reactor a constructor, and make its fields private.2023-03-08T19:21:33ZNick Mathewsonnickm@torproject.org2023-03-03T12:27:32Zurn:sha1:5586a29f62a7eb85bc5b7b4128602cab62962aabproto: Tweak documentation and names around CmdChecker.2023-02-27T13:14:15ZNick Mathewsonnickm@torproject.org2023-02-27T13:14:15Zurn:sha1:07473ed1fc110b8b48ef02bb288b1f50085dfa06tor-proto: Rename end_received.2023-02-17T16:56:53ZNick Mathewsonnickm@torproject.org2023-02-17T16:56:53Zurn:sha1:814563dfd6a3c8c4a7b97e5698f8d45550dc7c91
It can now indicate _any_ cell that means we can forget about a stream.
Use CmdChecker in our stream handling code.2023-02-17T16:52:09ZNick Mathewsonnickm@torproject.org2023-02-17T16:52:09Zurn:sha1:d81a9c9aadd43b93f9855aa33801fb5a926bf3b5
This change makes sure that open streams and half-closed streams
have the same stream-type-dependent state machines with respect to
which cells are acceptable.
Fixes #774.
Fixes #769.
tor-proto: Add a TODO about simplifying a common pattern.2023-02-15T15:51:03ZNick Mathewsonnickm@torproject.org2023-02-15T15:51:03Zurn:sha1:19c0dd153ad957fc108c59f578facbfc3e562d2a