mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.0 2022-04-25T17:06:26Z 2022-04-25T17:06:26Z Nick Mathewson nickm@torproject.org 2022-04-25T16:40:33Z urn:sha1:2f6bc6bdc431fa36de70a167eea777dcf3f60bf2 Remove all `use` statements for `TryFrom` and `TryInto`. These are now redundant in Rust 2021. 2022-03-17T16:03:34Z Nick Mathewson nickm@torproject.org 2022-03-17T15:52:15Z urn:sha1:764930b9cd8c63a4dd59229ad6298e6b27fb375c Each channel now remembers an OwnedChanTarget. Each circuit now remembers a vector of OwnedChanTarget to represent the path that it was constructed for. Part of #415. 2022-03-17T14:34:06Z Nick Mathewson nickm@torproject.org 2022-03-17T14:34:06Z urn:sha1:567995a7ca187a986d0f1d62a8648ab8c9347b2d This will help with #415 2022-02-15T14:57:03Z Nick Mathewson nickm@torproject.org 2022-02-15T14:57:03Z urn:sha1:6b611d6deae2e003ea81f459cd5e005c37ab50ce 2022-02-15T14:41:11Z Nick Mathewson nickm@torproject.org 2022-02-11T20:20:50Z urn:sha1:f23f375e42ef3237f9bbb7b8bfee47ecc9ced4a1 2022-02-03T16:27:57Z eta tor@eta.st 2022-02-03T16:27:57Z urn:sha1:e9087e1fed7193f0cf5b9f9d1078340f216745ed Fix severe reactor ordering problems See merge request tpo/core/arti!282 2022-02-03T15:04:28Z eta tor@eta.st 2022-02-02T14:21:17Z urn:sha1:24d12163f2a5b109adc1d40ad815efecf36cf499 A number of severe problems with the circuit reactor were fixed which could cause reordering of cells (which causes relays to terminate the circuit with a protocol violation, as they become unable to decrypt them). These mostly revolve around improper usage of queues: - The code assumed that a failure to place cells onto the channel would persist for the duration of a reactor cycle run. However, under high contention, this wouldn't always be the case. - This leads to some cells getting enqueued while others go straight through, before the enqueued cells. - To fix this, we block sending cells out of the channel while there are still some enqueued. - The hop-specific queues queued after encryption, not before. This was very brittle, and led to frequent mis-ordering. - This was fixed by making them not do that. This is arti!264 / 5bce9db5628126be2b736f228211174fe4132918 without the refactor part. 2022-02-02T18:34:26Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-02T18:18:16Z urn:sha1:b7fec1c8a4ee185b12648414242575e5aec5b581 Found via clippy::needless_borrow. In some cases I removed needless `[..]` too. See also: needless_borrow suggestion doesn't go far enough https://github.com/rust-lang/rust-clippy/issues/8389 2022-01-19T18:46:13Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T18:45:20Z urn:sha1:9a77b23cddee1ed378ac0af8c2b248c3880bc069 As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771025 It doens't really handle it. 2022-01-19T17:26:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T17:20:35Z urn:sha1:c4338999488cd332544c6d91cee6b42a36ebe569