mirrors/arti.git/crates/tor-proto/src/circuit/reactor.rs, branch arti-v0.0.3 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.3 2021-12-16T21:01:50Z tor-proto: Allow one meta-cell handler at a time. 2021-12-16T21:01:50Z Nick Mathewson nickm@torproject.org 2021-12-16T21:01:50Z urn:sha1:64257a10fae8d062a20c6fcc0c7c7787390e6e13 Previously the code would let us try to install a meta-cell handler before the old one was done, leading to possible confusion. tor-proto: set HalfStream::connected_ok right. 2021-12-16T16:48:39Z Nick Mathewson nickm@torproject.org 2021-12-16T16:48:39Z urn:sha1:51c4ca73f265558df6ae0c6766a02b228b8404be Previously we'd always set it to true, allowing one CONNECTED per half-closed stream even if the stream had already received a CONNECTED cell. This resolves an XXXX. Extend trace messages for destroy/truncated reasons. 2021-12-15T16:33:48Z Nick Mathewson nickm@torproject.org 2021-12-15T16:33:48Z urn:sha1:f73840544cdd79ce839b5ae0958d85db45f9b1ce It makes sense to put the method for human-readable strings onto the type itself, so that we can format these whenever they occur. I'm choosing the "human_str" method name here, since caret-generated types already have a to_str. I was thinking about using Display, but caret types already implement that. I've also moved the message from "warn!" to "debug!", since these aren't necessarily a problem condition. Merge remote-tracking branch 'origin/mr/191' 2021-12-15T15:46:58Z Nick Mathewson nickm@torproject.org 2021-12-15T15:46:58Z urn:sha1:1cf0b87eb75d45ba36b8b7c5619c13b7ae97e487 Merge branch 'check_put_return' into 'main' 2021-12-15T15:45:08Z eta tor@eta.st 2021-12-15T15:45:08Z urn:sha1:2e0ff665bb09cc979cd88dcce0eb6c1fc45f0a5e Always check whether stream-level SENDMEs are expected. Closes #261 See merge request tpo/core/arti!192 In reactor, use enums on whether to destroy circuits 2021-12-14T22:36:30Z Neel Chauhan neel@neelc.org 2021-12-14T22:36:30Z urn:sha1:043b97fecfe5d1e1da7bf8d1ba014d26df435023 Methodize the destroy circuit reason 2021-12-14T22:26:45Z Neel Chauhan neel@neelc.org 2021-12-14T22:26:45Z urn:sha1:b601d8b1476810e33550b2f007fe91396ed47ba8 Always check whether stream-level SENDMEs are expected. 2021-12-14T17:11:48Z Nick Mathewson nickm@torproject.org 2021-12-13T21:01:27Z urn:sha1:d5c2361d3f631c68b3aa16915d60df07b6c211ac (It's a protocol violation to get a SENDME when our send window is already full.) This patch makes SendWindow::put return a Result, so that it's easier to do the right thing with it. Closes #261. Actually decrement the stream-level SENDME window 2021-12-14T16:37:56Z eta tor@eta.st 2021-12-14T15:49:40Z urn:sha1:8d660cbcf1a655769425dd0a303e5446f6cb8542 arti!126 overhauled the `tor-proto` circuit reactor, but left out one very important thing: actually decrementing the SENDME window for streams (not circuits) when we send cells along them. Since the circuit-level SENDME window would often prevent us from running into a problem, this wasn't caught until my benchmarking efforts noticed it (in the form of Tor nodes aborting the circuit for a protocol violation). fixes arti#260 Handle TRUNCATED cells 2021-12-13T20:21:25Z Neel Chauhan neel@neelc.org 2021-12-13T20:19:57Z urn:sha1:2595f3f8c15f97f20becdaf059cfa0696fbedc8e