mirrors/arti.git/crates/tor-proto/src/circuit.rs, branch arti-v1.3.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.3.0 2024-10-22T13:06:32Z Merge branch 'mq-fix' into 'main' 2024-10-22T13:06:32Z Ian Jackson iwj@torproject.org 2024-10-22T13:06:32Z urn:sha1:2ceea6972e29fdf30187bb41207c0a3d77b0131d memquota: Fix account lifetime bugs, and arrange to test mq in shadow See merge request tpo/core/arti!2560 memquota: Fix resolve stream account lifetime 2024-10-21T10:11:20Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-10-16T15:25:28Z urn:sha1:a67433aa9a0a079d1e070d40000fdb74fb6bbc06 We need the mq account for the stream not to collapse. The ResolveStream object needs to contain a strong reference to it. Have begin_stream_impl return the StreamAccount, rather than taking it as a parameter. That makes this bug a little more obvious. It also centralises the StreamAccount creation. memquota: Fix circuit account lifetime (fmt) 2024-10-21T10:11:20Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-10-21T10:09:34Z urn:sha1:c017ccaf28fe1089ddd313fe0b874e6bc71546cd memquota: Fix circuit account lifetime (clippy churn) 2024-10-21T10:11:20Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-10-16T17:01:36Z urn:sha1:0be7b09361f1820179f9ec1f6d995c773b726433 Now that it doesn't call CircuitAccount::new() it has no error paths, and clippy demands we remove the Result, so it must once again become infallible. memquota: Fix circuit account lifetime 2024-10-21T10:11:20Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-10-16T15:08:49Z urn:sha1:09b80b32e316634324b0f99258df66773642da88 We foolishly made *two* CircuitAccounts, one of which gets immediately dropped. But we need to hold onto the account somewhere, because an mq_queue doesn't keep the account alive. Otherwise everything breaks when mq tracking is enabled. tor-proto: Reinstate circuit hop check in test_create() 2024-10-16T14:00:58Z Neel Chauhan neel@neelc.org 2024-10-16T14:00:58Z urn:sha1:117554d96666d15d122d5938187c5278ef7399b3 Replace _ => panic!() in tor-proto 2024-10-15T11:11:46Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-10-15T11:11:46Z urn:sha1:6aa00c0e39ae71a9a5e531f01668d2c3b8c3627b Merge branch 'mq-circ' into 'main' 2024-10-10T13:29:10Z David Goulet dgoulet@torproject.org 2024-10-10T13:29:10Z urn:sha1:d28fd76d10236cbacb9c949dfaa6ab495504bdd9 Use memquota queue for channel->circuit RX data Closes #1682 See merge request tpo/core/arti!2518 Apply deferred rustfmt churn 2024-10-09T17:21:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-10-09T17:21:09Z urn:sha1:fafe03628c3a6f670b052cfa8ac782843d72ea1a memquota: Use an mq_queue for channel->circuit RX queue 2024-10-09T17:19:41Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-10-09T16:45:07Z urn:sha1:bfa67c34da9357e412758507c312c6b92c2f3133 Fixes #1682. (This involves some noise in the tests.)