mirrors/arti.git/crates/tor-proto/src/circuit.rs, branch arti-v1.2.5

proto: Add a test for closing streams.

2024-05-29T11:28:05Z

This test verifies that when we invoke the code to close a stream, an END message is actually sent. The test comes in two versions: * `drop_stream` closes the stream by dropping it. It currently passes on main. * `close_stream` closes the stream by running `AsyncWriteExt::close` on the writer. It is a regression test for #1368. It currently fails on main.

proto: Improve documentation about DataStream lifetimes and closing

2024-05-29T11:28:05Z

In particular, clarify that dropping the DataWriter on its own does nothing unless the DataReader is also dropped. Related to #1368.

proto: Make DataWriter::close actually do something.

2024-05-29T11:28:01Z

Previously we had a bug where `::close` (or `shutdown` in tokio-land) would not actually have any effect. It _would_ drop the `StreamTarget` held by the `DataWriter`, but since the `DataReader` also held a `StreamTarget`, the MPSC channel would not get closed, and the circuit reactor would not realize that the stream wanted to shut down. Now we use `mpsc::Sender::close_channel` to make our closes effectual. Closes #1368. Additionally, we fix a bug where `poll_close()` never actually did anything if the buffer had nothing in it when it was called. Previously, `poll_flush_impl()` would exit immediately if it had no data to flush. That isn't what we want when we are closing!

proto: Make Channel explicitly Arc<.>

2024-05-16T16:24:12Z

Previously, Channel was a type that you could Clone that implicitly its state. Now, Channel always appears as an Arc. This change has several benefits: * It makes the relationship between Channel struct and the underlying channel more clear. * It enables Channel to participate in the RPC system, where everything has to be an Arc<.> * It enables us to have a Weak, if we ever want to. * It will let us move various members out of ChannelDetails. We did this change a while ago with ClientCirc.

proto: Fix compilation with stream-ctrl but not experimental-api.

2024-05-14T12:04:03Z

Make filter conditional, to fix build with hs-service disabled.

2024-03-26T16:55:05Z

Rename the old IncomingStreamRequestContext to StreamReqInfo.

2024-03-26T16:55:05Z

(Doing this to prevent us having two structs with the same name.)

Add an IncomingStreamRequestFilter to check early properties

2024-03-26T16:55:05Z

Based on designs in #1124. Note that there is a TODO here about a hack I had to do to appease the borrow checker.

We now need circuit::handshake to exist unconditionally.

2024-03-26T15:43:43Z

Refactor the logic for constructing crypt layers.

2024-03-26T15:43:43Z

The key insights here are: - That relay cell format and crypto protocols aren't orthogonal: Once we have GCO, it will require V1. - That we only need the actual functions for layer construction to be generic; we don't need to proliferate generic parameters everywhere. - That the circuit::handshake module already does most of what we want.