mirrors/arti.git/crates/tor-proto/src/circuit.rs, branch arti-v1.1.10mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.102023-10-26T15:14:40ZAdd a caret_int HandshakeType for HTYPE constants2023-10-26T15:14:40ZJim Newsomejnewsome@torproject.org2023-10-25T19:30:45Zurn:sha1:87081e51b503eb704d44e611f1ece614f42160f5Change `CircId` to never be zero2023-10-25T20:35:12ZJim Newsomejnewsome@torproject.org2023-10-24T18:47:06Zurn:sha1:3fba6685fec3437f4afa3b3e8f94b6448117e73e
This changes the internal representation to be `NonZeroU32` instead of
just `u32`.
Various places where a circuit ID is optional now use `Option<CircId>`.
Fixes a bug in `CircIdRange::sample` that would previously return a
circuit ID of 0, when the rng returned 0x8000_0000 for a low range.
Convert StreamId to NonZeroU162023-10-25T20:34:55ZJim Newsomejnewsome@torproject.org2023-10-23T22:57:46Zurn:sha1:48d95b8be53177d34012c53dd84ed888ebfb5cc8Fix rustdoc link warnings/errors.2023-10-20T05:12:23ZNick Mathewsonnickm@torproject.org2023-10-20T05:12:23Zurn:sha1:df6a6c50c98b0e9e63aad2bb66f3f9a211994029proto: Revise the behavior of IncomingStream::discard().2023-10-19T17:15:10ZNick Mathewsonnickm@torproject.org2023-10-18T14:30:35Zurn:sha1:1b2a4de2eb6a11157879cb53839eaee9e658ba4d
Because dropping a `StreamTarget` causes the circuit reactor to send
an End, the previous do-nothing implementation of `discard()` wasn't
sufficient to cause the request to be ignored without sending an
End.
This commit modifies our "close pending stream" behavior to only
optionally send an End message. To avoid confusion, I'm using a new
`CloseStreamBehavior` enum rather than an `Option<End>`, since we
had previously used `None` in some cases to indicate a default
(misc) end message.
proto: Remove TODOs about panics on double-close.2023-10-19T17:15:10ZNick Mathewsonnickm@torproject.org2023-10-18T14:02:11Zurn:sha1:658ff9b476b85f019bd4d3f0268e8d16404e6007
Now that `StreamMap::terminate` no longer panics, and now that it
permits the kind of double-call that we allow, we can close #1065.
Closes #1065.
Add comments about another problem with close_pending().2023-10-17T13:04:24ZNick Mathewsonnickm@torproject.org2023-10-17T13:04:24Zurn:sha1:4fa9e1644870e1a0f555ff5837214e2084e40707
See #1065 for more information here.
proto: Make StreamTarget::close() misuse less likely.2023-10-17T12:41:44ZNick Mathewsonnickm@torproject.org2023-10-17T12:39:39Zurn:sha1:308a27f0ac25c4608fd08d7c68fd1c5b305a8428
It turns out that we can make `IncomingStream::reject()` consume
self, thus making it impossible to hit the double-close error
from outside the `tor-proto` crate.
Also, we rename `StreamTarget::close()` to `close_pending()` to
better reflect its limited applicability.
oneshot: Use veneer in tor-proto2023-10-11T15:19:21ZIan Jacksonijackson@chiark.greenend.org.uk2023-10-11T14:03:27Zurn:sha1:f185eee7ddd0df75d98b03e64e74dd9235b6d1f4tor-proto: Make allow_stream_requests() not return a Result2023-09-27T17:32:07ZNick Mathewsonnickm@torproject.org2023-09-26T18:42:00Zurn:sha1:8cdd30491201c3a8d54e482ef4904a51900ea399
The function never yields anything but an `Ok`, so we can
simplify its type.
(Not a stable feature, so no semver entry needed)