mirrors/arti.git/crates/tor-proto/src/channel, branch arti-v2.0.0

Merge branch 'unused-async-lint' into 'main'

2026-01-28T17:46:56Z

maint/add_warning: Deny clippy::unused_async Closes #2328 See merge request tpo/core/arti!3613

proto: Add an exception for clippy::unused_async

2026-01-27T18:19:03Z

proto: Remove unnecessary async in channel reactor

2026-01-27T18:09:52Z

This resolves a warning triggered by the newly-introduced `#[deny(clippy::unused_async)]`.

clippy: Fix missing doc for non-Linux builds

2026-01-27T15:02:57Z

proto: Add missing use for tests

2026-01-22T16:16:44Z

Signed-off-by: David Goulet

proto: Use the channel codec channel type

2026-01-22T16:16:44Z

Remove the channel type from Unverified and Verified channels and instead use the channel type in the underlying channel codec. The codec requires such type in order to restrict messages sets. Instead of duplicating it, this commit simply makes it that there is now only a single channel type attached to a channel structure. The resulting `struct Channel` in the end gets it copied from the channel codec as the framed_tls gets split and given to the `Reactor`. Down the line, we need a channel type attached to the `Channel` in order to know if it is a client or not and authenticated or not. Signed-off-by: David Goulet

proto: Put rsa_id and rsa_cert_digest together

2026-01-22T16:16:44Z

Avoid having one None and the other Some which would be a bug. Signed-off-by: David Goulet

proto: Remove uneeded code in the unverified inner check()

2026-01-22T16:16:44Z

We can't get into the UnverifiedChannel::check() without wanting to verify our identities and authenticate. This validation has moved before calling check() for the relay channel type. Signed-off-by: David Goulet

proto: Implement FinalizableChannel for an unverified relay channel

2026-01-22T16:16:44Z

Reason for this is so we can use the type system to enforce that a client/bridge<-> relay channel can never become verified and thus in the code path of authentication. In other words, when check() is called, without an authentication cell, we can't authenticate or even verify the identities so we immediately return "self" which in this case is the UnverifiedRelayChannel. That channel can be finish()-ed to yield a Channel that can never be considered authenticated. Signed-off-by: David Goulet

proto: Make CERTS cell optionnable for UnverifiedChannel

2026-01-22T16:16:44Z

This requires to make a series of cert and digest also optionnable in the VerifiedChannel. This change is needed because as a relay responder, you might get the CERTS or not depending on if the other side wants to authenticate. Client and bridges do not authenticate and thus it is expected to not have a CERTS cell. This leads to the UnverifiedChannel::check() function to return early with a VerifiedChannel without any identity attached to it. Signed-off-by: David Goulet