mirrors/arti.git/crates/tor-proto/src/channel/reactor.rs, branch arti-v1.2.7

extract tor_async_utils::oneshot into ::oneshot-fused-workaround

2024-08-28T14:27:46Z

Having this in the `tor-async-utils` crate prevents us from doing both of the following without introducing a circular dependency: * using it in `tor-rtmock` (which we currently do, particularly in tests). * using `tor-rtmock` to test things in `tor-async-utils`. We don't do this yet, but it is generally sensible to do so. In particular we want to move the `stream_peak` module there, which is currently tested with `tor-rtmock`. Moving this into its own crate avoids this circular dependency.

proto: Divide up some elements of ChannelDetails.

2024-05-16T16:24:12Z

Previously ChannelDetails had a double duty: It held elements shared among the clones of a Channel, and it also held elements shared between the Channel and the Reactor. But now that Channel doesn't have to implement Clone, we can more the non-Reactor elements into Channel itself. This change may improve cache locality a bit, and should make it a little easier to follow the channel code. I've also moved unique_id out of ChannelDetails into Channel _and_ Reactor: it is small, immutable, and used all the time in logging.

proto: Make Channel explicitly Arc<.>

2024-05-16T16:24:12Z

Previously, Channel was a type that you could Clone that implicitly its state. Now, Channel always appears as an Arc. This change has several benefits: * It makes the relationship between Channel struct and the underlying channel more clear. * It enables Channel to participate in the RPC system, where everything has to be an Arc<.> * It enables us to have a Weak, if we ever want to. * It will let us move various members out of ChannelDetails. We did this change a while ago with ClientCirc.

Downgrade some messages to trace

2023-11-29T18:51:30Z

These messages are very verbose and I doubt anyone will want them, usually, even when debugging.

Change `CircId` to never be zero

2023-10-25T20:35:12Z

This changes the internal representation to be `NonZeroU32` instead of just `u32`. Various places where a circuit ID is optional now use `Option`. Fixes a bug in `CircIdRange::sample` that would previously return a circuit ID of 0, when the rng returned 0x8000_0000 for a low range.

oneshot: Use veneer in tor-proto

2023-10-11T15:19:21Z

proto: methods to wait until a channel/circuit is shut down.

2023-08-04T17:37:28Z

The implementation here is perhaps excessively simple: we put a `oneshot::Sender` in the `Reactor` object, and a `Shared` in the circuit or channel. When the reactor is dropped, any copy of the `Shared` will yield `Err(Cancelled)`. I'm marking these methods as experimental because I'm not sure I've thought of all the implications here, and we might want to change things around. Down the road, these methods might want to yield a `Result<>` indicating why the reactor was shut down. This feature was inspired by a request from Saksham Mittal, and a felt need while working on !1472.

async-utils: rename SinkExt to SinkPrepareExt

2023-04-19T16:38:26Z

Move functionality from tor_basic_utils to tor_async_utils

2023-03-29T17:57:11Z

This commit is mostly code movement; I'd recommend reviewing it with git's `--color-moved` option.

Rename OpenClientChan{Msg,Cell} => OpenChan{Msg,Cell}S2C

2023-02-09T15:20:31Z