mirrors/arti.git/crates/tor-proto/src/channel/reactor.rs, branch arti-v0.4.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.02022-05-23T10:28:05Zprepare_send_from: clippy: Replace some or_else with or2022-05-23T10:28:05ZIan Jacksonijackson@chiark.greenend.org.uk2022-05-20T15:49:30Zurn:sha1:2fc6c8a194fa668e5bdb9d94d25e29c5e1666a21channel: Provide and use Sink::prepare_send_from2022-05-23T10:28:05ZIan Jacksonijackson@chiark.greenend.org.uk2022-05-18T15:02:52Zurn:sha1:793782acc80c05e2d2e125c65721c7a0b967d113
This is a general-purpose implementation of the ad-hoc approach
currently taken in (eg) crates/tor-proto/src/channel/reactor.rs,
with an API intended to defned against the more obvious mistakes.
This allows us to separate the two concerns: the channel reactor can
focus on handling channel cells and control messages and is over 2.5x
shorter.
The complexity of the manual sink implementation, and the machinery
needed to avoid having to suspend while holding an item, are dealt
with separately. That separate implemenation now has proper
documentation. (Tests are in the nest commit to avoid this one being
even more unwieldy.)
We use `extend` to define this as an extension trait. A competitor is
`ext` but in my personal projects I have found `extend` slightly
better.
clippy: Change a binding to (), and allow clippy::let_unit_value2022-05-11T17:52:12ZIan Jacksonijackson@chiark.greenend.org.uk2022-05-11T14:30:28Zurn:sha1:0cc94d449ed5853838221a882f66c7838a36ee3f
The type of ret.map_err(codec_err_to_chan)? is (). ISTM that
writing `let () = ` makes it clear that there is nothing there,
but the lint forbids this.
This lint is warn by default and trips here for me on current nightly.
It seems wrong to me. We should be able to make it clear to the
reader that there is nothing here - note how this differs from the
lines below where Ready contains msg. A let () binding is a good way
to do that.
I think the lint allow ought to be added everywhere, but that doesn't
seem easy right now - see this issue about maint/add_warning:
https://gitlab.torproject.org/tpo/core/arti/-/issues/469
squash! Bump every crate's edition to 2021.2022-04-25T17:06:26ZNick Mathewsonnickm@torproject.org2022-04-25T16:40:33Zurn:sha1:2f6bc6bdc431fa36de70a167eea777dcf3f60bf2
Remove all `use` statements for `TryFrom` and `TryInto`. These are
now redundant in Rust 2021.
Channel: Expose our view of whether the clock is skewed, and the age2022-04-07T14:07:35ZNick Mathewsonnickm@torproject.org2022-04-06T19:29:24Zurn:sha1:7656ab09319aacbc8ef0e89e34a7dd5ce0ba1d85
of a channel.
At first I wanted to have this information not be a part of channels
at all, but it is a fairly tiny amount of data, and the alternatives
are pretty crufty.
tor-proto: Remember peer information in circuit and channel2022-03-17T16:03:34ZNick Mathewsonnickm@torproject.org2022-03-17T15:52:15Zurn:sha1:764930b9cd8c63a4dd59229ad6298e6b27fb375c
Each channel now remembers an OwnedChanTarget.
Each circuit now remembers a vector of OwnedChanTarget to represent
the path that it was constructed for.
Part of #415.
remove usage of dbg!(..)2022-02-28T17:20:34Ztrinity-1686atrinity@deuxfleurs.fr2022-02-28T16:46:28Zurn:sha1:55a14334992f83da923a33d83799d5118d1e4d8f
it's making rust-nightly job fail
proto: Refactor conversion from CodecError to Error2022-02-24T18:23:42ZNick Mathewsonnickm@torproject.org2022-02-24T18:23:42Zurn:sha1:d8120e1649e4e8f039666ff1c3aedff5f1310154
Remove default conversion; instead use a specific conversion in each
of the two modules that need to do it.
tor-proto: Rename BadHandshake to BadCircHandshake2022-02-23T15:39:08ZNick Mathewsonnickm@torproject.org2022-02-23T15:07:49Zurn:sha1:d42b932ed93c5f4d4204d933e4ea798c21c4d02d
(We'll have a BadChanHandshake soon.)
Replace as_mut with deref impl for MutCircEnt2022-02-16T22:23:16ZYuan Lyulyuyuan92@gmail.com2022-02-16T22:23:16Zurn:sha1:7ab840785ec4bc91b5d1230f7e0544fe6866178a