mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-dirmgr-v0.5.1 2022-06-23T19:42:45Z 2022-06-23T19:42:45Z Nick Mathewson nickm@torproject.org 2022-06-23T19:42:45Z urn:sha1:38004a4f4dd3aa99b81b6585039e81dc77c17f32 Some of these were for decoding particular objects (we now say what kind of objects), and some were unrelated tor_cert errors that for some reason we had shoved into a tor_bytes::Error. There is now a separate tor_cert::CertError type, independent from tor_cert's use of `tor_bytes::Error` for parsing errors. 2022-06-23T18:59:52Z Nick Mathewson nickm@torproject.org 2022-06-23T18:59:52Z urn:sha1:35b7b8a47ad96f5eee032fab7900b3b29bf2fa73 Failing to encode is fundamentally different from failing to decode. We now treat those separately, and describe _what_ we failed to encode or decode. 2022-06-23T18:35:26Z Nick Mathewson nickm@torproject.org 2022-06-23T18:35:26Z urn:sha1:92fd9fb0dec25ddd45a4428603db99bad8d72661 This avoids adding additional information for now; that will come on the next commits. 2022-06-08T10:24:26Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-06T15:39:54Z urn:sha1:e8fc1036d3d8de0da72329071b63a64e8f5d98eb The channel reactor is going to want to be able to sleep so that it can do padding, so it needs a SleepProvider. 2022-04-11T16:34:16Z Nick Mathewson nickm@torproject.org 2022-04-11T16:31:05Z urn:sha1:4efe45ce6e14672625dea392b93da9cf43c72ec1 2022-04-07T14:15:28Z Nick Mathewson nickm@torproject.org 2022-04-07T14:01:19Z urn:sha1:9160b55c57e9b2d68b82059139a2be0dd7954b8a Fortunately, we don't need a separate type here: authenticated clock skew can only come attached to a `tor_proto::Error`. We also remove skew from `tor_proto::Error::HandshakeCertsExpired`, since it would now be redundant. 2022-04-07T14:07:35Z Nick Mathewson nickm@torproject.org 2022-04-06T19:29:24Z urn:sha1:7656ab09319aacbc8ef0e89e34a7dd5ce0ba1d85 of a channel. At first I wanted to have this information not be a part of channels at all, but it is a fairly tiny amount of data, and the alternatives are pretty crufty. 2022-03-23T12:49:36Z Nick Mathewson nickm@torproject.org 2022-03-23T12:49:36Z urn:sha1:791394cd2b455646c5e8938e7592d73b28c7977b tor-proto: add the ability to learn clock skew from NETINFO cells See merge request tpo/core/arti!410 2022-03-23T12:24:36Z Nick Mathewson nickm@torproject.org 2022-03-14T18:33:11Z urn:sha1:0b2cf533ee5771fdb16255652837af69c316642e We now check the handshake certificates unconditionally, and only report them as _expired_ as a last resort. (Rationale: if somebody is presenting the wrong identity from a year ago, it is more interesting that they are presenting the wrong ID than it is that they are doing so with an expired cert. We also now report a different error if the certificate is expired, but its expiration is within the range of reported clock skew. (Rationale: it's helpful to distinguish this case, so that we can blame the failure on possible clock skew rather than definitely attributing it to a misbehaving relay.) Part of #405. 2022-03-23T12:24:36Z Nick Mathewson nickm@torproject.org 2022-03-14T15:51:06Z urn:sha1:3885a2c05b64e6d071adfabdf5eb957fab001a5d NETINFO cells, which are sent in every handshake, may contain timestamps. This patch adds an accessor for the timestamp in the Netinfo messages, and teaches the tor-proto code how to compute the minimum clock skew in the code. The computation isn't terribly precise, but it doesn't need to be: Tor should work fine if your clock is accurate to within a few hours. This patch also notes a Y2038 problem in the protocol: see torspec#80. Part of #405.