mirrors/arti.git/crates/tor-proto/src/channel/handshake.rs, branch arti-v1.6.0

opentelemetry: Add some instrument macros.

2025-09-24T19:23:32Z

I've added these in places that are useful for the debugging that I've been doing.

proto: Move is_authenticating() into the base initiator handshake trait

2025-09-02T15:43:31Z

Initiator always know if they will authenticate or not. Responder is different as a relay doesn't know until the end of the handshake if it is responding to a relay or a client. Signed-off-by: David Goulet

proto: Various channel handshake fixes

2025-09-02T15:43:31Z

These are following the review of MR 3182. They are put in a single commit because the git absorb has a large amount of conflicts on rebase and this commit allows the reviewers to see what happened. The base branch was rebased on main due to the need for 3184. Signed-off-by: David Goulet

proto: Fix unit tests after changes

2025-09-02T15:43:31Z

Signed-off-by: David Goulet

proto: Add a helper to calculate the handshake clock skew

2025-09-02T15:43:31Z

In the spirit of avoidin code duplication. Signed-off-by: David Goulet

proto: Add a channel initiator handshake base trait

2025-09-02T15:43:31Z

All initiator handshake will implement this in order to get access to the helper function to receive the relay responder cells. Relay will implement this in future commits. Signed-off-by: David Goulet

proto: Introduce a ChannelBaseHandshake trait

2025-09-02T15:43:31Z

Client and relay handhsake share a lot of code because they both send/recv the same cells, just handles them differently for verification. This is the base trait for all handshake implementing basic getters and VERSIONS cell handling. This will allow the RelayInitiatorHandshake and RelayResponderHandshake to use this common code. See, traits are fun. Win-win-win. Signed-off-by: David Goulet

proto: Put in a ChannelFrame into the client handshake

2025-09-02T15:43:31Z

The ClientInitiatorHandshake holds a "tls" sink but the very first thing we do is transform it to a ChannelFrame. Instead, just store the frame to the object directly so we can then use a channel frame uniformily accross its lifetime. This will be useful for the future refactoring paving the way for relay channel authentication. Signed-off-by: David Goulet

proto: Only allow VERSIONS cell for the new handshake state

2025-08-27T15:04:24Z

Due to this, it is not possible to get a VPADDING before because it requires a link protocol version to decideon the encoding: https://gitlab.torproject.org/tpo/core/torspec/-/issues/366 Signed-off-by: David Goulet

proto: Remove the AUTHORIZE as a parsable cell

2025-08-21T15:59:37Z

The AUTHORIZE cell command is simply reserved but not defined. The tor specification, at this point in time, is allowing such cell before the handshake starts but it is very unclear on what ordering is allowed nor how many can are allowed. C-tor silents drop them like VPADDING and so clearly unused. Instead of dealing with it, simply remove its support but keeping its reserved number. Signed-off-by: David Goulet