mirrors/arti.git/crates/tor-proto/src/channel/handshake.rs, branch arti-v1.5.0

proto: Only allow VERSIONS cell for the new handshake state

2025-08-27T15:04:24Z

Due to this, it is not possible to get a VPADDING before because it requires a link protocol version to decideon the encoding: https://gitlab.torproject.org/tpo/core/torspec/-/issues/366 Signed-off-by: David Goulet

proto: Remove the AUTHORIZE as a parsable cell

2025-08-21T15:59:37Z

The AUTHORIZE cell command is simply reserved but not defined. The tor specification, at this point in time, is allowing such cell before the handshake starts but it is very unclear on what ordering is allowed nor how many can are allowed. C-tor silents drop them like VPADDING and so clearly unused. Instead of dealing with it, simply remove its support but keeping its reserved number. Signed-off-by: David Goulet

proto: Return AUTHORIZE, VPADDING and VERSIONS at handshake

2025-08-21T15:07:32Z

When starting a handshake, we were only expecting a VERSIONS which is not what the protocol say. An AUTHORIZE and VPADDING can arrive before a VERSIONS. Signed-off-by: David Goulet

proto: Rename OutboundClientHandshake

2025-08-20T17:22:16Z

Use the specification terminology which is also the same for ChannelType. Part of #1597 Signed-off-by: David Goulet

proto: Make the OutboundClientHandshake use new cell handler

2025-08-20T17:22:16Z

Use the ChannelFrame<> for the entirety of the outbound client handshake that is the ClientInitiator channel type. With this change, the codec.rs code is not needed anymore along its CodecError as well which has been normalized onto the crate::Error instead in order to simplify error handling and avoid duplication of error types. Unit tests have been modified to reflect this change of what can be done with a channel frame. Also renamed to focus on client behavior. Part of #1597 Signed-off-by: David Goulet

proto: Add ChannelType enum

2025-08-20T16:41:03Z

The ChannelType indicates the type of channel in order to dictate which message is allowed on it. The value use the Initiator and Responder terminology from tor-spec documents. At this commit, we only have client channel meaning the "ClientInitiator" type. In future commits, the channel type will be used by the channel reactor to restrict which message is allowed or not. Part of #1597 Signed-off-by: David Goulet

Switch Cargo.toml files to edition 2024.

2025-08-07T15:28:36Z

First, run ``` git grep -l "^edition =" | xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;' ``` Second, manually verify that all Cargo.toml files have changed, and nothing else has changed. Third, run cargo fmt again.

tor-proto: Log channel, circuit, stream identifiers as structured fields.

2025-06-12T18:02:30Z

This changes the `tor-proto` logs to not be prefixed with a channel/circuit/stream ID, but rather to have these IDs attached to the log as structured fields. This change is in preparation for the switch to using `TunnelId`s in the tunnel reactor instead of circuit `UniqId`s. The reason for the change to use structured fields is because future logs will likely need to log the `UniqId`s of the circuits in a tunnel, which will need to either be formatted somehow in the logs, or logged as a structured field (the latter seems like the better option, hence this preparatory change). IMO we should favor structured fields over formatted strings in the logs in general, but that is a bigger project, so I am only doing a spot fix for now.

tor-proto: remove `use asynchronous_codec as futures_codec`

2025-02-06T16:43:27Z

Closes #1690.

tor-proto: Pass a StreamOps handle to the channel reactor.

2025-01-15T13:49:17Z