mirrors/arti.git/crates/tor-proto/src/channel/handshake.rs, branch arti-v1.1.0

Merge branch 'rename_for_to_from' into 'main'

2022-10-25T11:53:57Z

tor-cell: Rename for_client and for_relay See merge request tpo/core/arti!793

linkspec: Remove now-useless declared_peer_addr

2022-10-24T12:59:12Z

The singleton variation here is almost never what we want.

tor-cell: Rename for_client and for_relay

2022-10-21T11:21:52Z

This commit renames the for_client and for_relay functions to from_client and from_relay respectively, in order to indicate their origin, as the term "for" is more likely to indicate a destination, which is not true in that situation.

Change multiplicity of ChannelMethod and addresses

2022-10-11T12:53:31Z

Now each `ChanTarget` has at most one `ChannelMethod`, and only `Direct` `ChannelMethods` can have multiple addresses. Closes #600.

Clarify limits on socket address from ChannelMethod

2022-10-06T19:13:05Z

tor-linkspec: Remove the old OwnedFoo::new() functions

2022-10-06T19:13:05Z

These are now builders.

tor-proto: Preserve the ChannelMethod, not the SocketAddr

2022-10-06T19:13:05Z

channel padding: Properly advertise link protocol 5

2022-08-17T09:54:41Z

We already actually send and negotiate the padding, since !657, but we ought to negotiate a protocol version where that's not a violation! As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/657#note_2828354

tor-proto: Unify the check_match code in channel and handshake

2022-08-10T14:39:47Z

This had to become a new internal function, since at the point that the handshake needs this code, it does not yet have a Channel to use. This change made the error messages in the handshake code more informative: and now they require a regex to check. Later, we might want to defer formatting these strings, but I don't think we need to do it now.

Final (?) API revisions for tor-linkspec

2022-08-10T14:39:37Z

With this change, each individual identity type becomes optional. The functions that expose them unconditionally are now in a "legacy" trait that only some downstream types are expected to implement. There are new convenience APIs in HasRelayIds: * to return Option<&keytype>, * to see if one identity-set contains another. This commit will break several downstream crates! For the reviewer's convenience, I will put the fixes for those crates into a series of squash! commits on this one. tor-netdir ---------- Revise tor-netdir to accept optional identities. This required some caveats and workarounds about the cases where we have to deal with a key type that the tor-netdir code does not currently recognize at all. If we start to add more identity types in the future, we may well want more internal indices in this code. tor-proto --------- In order to make tor-proto support optional identities, there were fewer changes than I thought. Some "check" functions needed to start looking at "all the ids we want" rather than at "the two known IDs"; they also needed to accommodate that case where we don't have an ID that we demand. This change will also help with bridges, since we want to be able to connect to a bridge without knowing all of its IDs up front. The protocol currently _requires_ the two current ID types in some places. To deal with that, I added a new `MissingId` error. I also removed a couple of unconditional identity accessors for chanmgr; code should use `target().identity(...)` instead. tor-chanmgr ----------- This is an incomplete conversion: it does not at all handle channel targets without Ed25519 identities yet. It still uses those identities to index its internal map from identity to channel; but it gives a new `MissingId` error type if it's given a channel target that doesn't have one. We'll want to revise the map type again down the road when we implement bridges, but I'd rather not step on the channel-padding work in progress right now. tor-guardmgr ------------ This change is mostly a matter of constructing owned identity types more sensibly, rather than unwrapping them directly. There are some places marked with TODOs where we still depend on particular identity types, because of how the directory protocol works. This will need revisiting when we add bridge support here. tor-circmgr ----------- These changes are just relatively simple API changes in the tests.