mirrors/arti.git/crates/tor-proto/src/channel/handshake.rs, branch arti-v0.1.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.1.0 2022-02-24T18:23:42Z proto: Refactor conversion from CodecError to Error 2022-02-24T18:23:42Z Nick Mathewson nickm@torproject.org 2022-02-24T18:23:42Z urn:sha1:d8120e1649e4e8f039666ff1c3aedff5f1310154 Remove default conversion; instead use a specific conversion in each of the two modules that need to do it. tor-proto: refactor handshake protocol errors to a different type 2022-02-23T15:39:08Z Nick Mathewson nickm@torproject.org 2022-02-23T15:35:09Z urn:sha1:74a5ce863553780fadc1afb926a14cfb8426f367 This helps the user distinguish between protocol violations that happen when connecting to the tor network from those that happen while connected. Closes #358. tor-proto: Split IoErr based on when it occurs 2022-02-23T15:38:48Z Nick Mathewson nickm@torproject.org 2022-02-23T15:01:28Z urn:sha1:afa49eac8f45ea34a419e7a8cef7bb03026b5c75 We want to distinguish handshake failures from errors later on in the channel's lifetime. Closes #359. Update tor-proto errors to latest API. 2022-02-15T14:57:03Z Nick Mathewson nickm@torproject.org 2022-02-15T14:57:03Z urn:sha1:6b611d6deae2e003ea81f459cd5e005c37ab50ce tor-proto: use InternalError for internal errors. 2022-02-15T14:41:11Z Nick Mathewson nickm@torproject.org 2022-02-11T20:20:50Z urn:sha1:f23f375e42ef3237f9bbb7b8bfee47ecc9ced4a1 handshake: Use read_exact, not read and checking len 2022-01-19T18:45:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T18:38:00Z urn:sha1:6c5e099be99fc7e756244f72486e92adb8b5d3ac read_exact has a loop in it, which we need. This means we end up separating the two sites that generate the "not a relay" error, so we need to fish out the error construction. As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/249#note_2771023 clippy: Rename a `from_foo` method that doesn't do conversion 2022-01-19T17:26:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T17:20:35Z urn:sha1:c4338999488cd332544c6d91cee6b42a36ebe569 Fix two bugs related to incomplete read/write 2022-01-19T17:17:56Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-01-19T17:17:56Z urn:sha1:1d5a480f79e7d878ff291e6e8fc5225e17328919 Discovered by clippy fix nightly clippy errors 2021-12-09T11:16:23Z Trinity Pointard trinity.pointard@gmail.com 2021-12-09T11:16:23Z urn:sha1:9753a7ee06d1dad9b9dbaa1653593bb545d4cf59 Resolve roughly half of the XXXXs. 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231.