mirrors/arti.git/crates/tor-proto/src/channel.rs, branch arti-v1.2.8 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.8 2024-08-28T14:27:46Z extract tor_async_utils::oneshot into ::oneshot-fused-workaround 2024-08-28T14:27:46Z Jim Newsome jnewsome@torproject.org 2024-08-22T19:20:36Z urn:sha1:46f7f01092e6ac55e3e958dc3a2228b1d36e26a1 Having this in the `tor-async-utils` crate prevents us from doing both of the following without introducing a circular dependency: * using it in `tor-rtmock` (which we currently do, particularly in tests). * using `tor-rtmock` to test things in `tor-async-utils`. We don't do this yet, but it is generally sensible to do so. In particular we want to move the `stream_peak` module there, which is currently tested with `tor-rtmock`. Moving this into its own crate avoids this circular dependency. `tor_proto::channel`: update comment to point to `tor-chanmgr` 2024-08-27T14:33:11Z Jim Newsome jnewsome@torproject.org 2024-08-27T14:33:11Z urn:sha1:adada9b92f278cdb0a4a1e1fbdef91d0ec9c4a4d Fix clippy::doc_lazy_continuation 2024-07-08T10:36:25Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-07-08T10:31:47Z urn:sha1:c4fe208c7184c020b5418840ebc5f4044c1601c6 Rename OptTimestamp to AtomicOptTimestamp 2024-06-24T14:53:13Z Neel Chauhan neel@neelc.org 2024-06-24T14:53:13Z urn:sha1:8239634692732fe6c3c369038d243341459b1a83 ChannelSender::poll_ready_unpin_bool: move to util 2024-05-29T11:16:19Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T11:15:39Z urn:sha1:237eb7a53f8953b8b6697ff110e1aec686b19d50 This is where it belongs. ChannelSender::poll_ready_unpin_bool: extension trait 2024-05-29T11:16:15Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T11:15:08Z urn:sha1:e0115adb172001a84867e98520341a0ad1b96628 This makes this available for any Sink + Unpin. Which we want because we're about to wrap our ChannelSender in a Sink wrapper. It's in the wrong place now; we'll move it in a moment. ChannelSender::poll_ready_unpin_bool: rename from poll_ready 2024-05-29T11:15:53Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T10:00:44Z urn:sha1:ca05a4dcb9979c6916cd1f0d7ccc74af433969e0 This would otherwise shadow the poll_ready method, which is confusing. Also this paves the way for making it available for any Sink + Unpin. Improve the docs somewhat to explain what this thing actually is. ChannelSender::poll_ready inherent method: Don't discard error 2024-05-29T09:53:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T09:44:14Z urn:sha1:71e28f8c47477c025ce0fd2375de8fbdfcdf85b4 I think this error was in fact always Error::CircuitClosed because it came from ChannelClosed.into(). Anyway, we shouldn't squash it. Now this function has semantics identical to Sink::poll_ready, just a slightly different signature. ChannelSender::poll_ready inherent method: Avoid apparent discard 2024-05-29T09:53:49Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T09:43:10Z urn:sha1:850ce5400a13d81abeb14f64c5ab5a85f583fc03 Make it clear we're discarding `()`, not an actual value. ChannelSender::poll_ready inherent method: Use Sink:poll_ready 2024-05-29T09:53:39Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-05-29T09:41:45Z urn:sha1:6d67dfc5af077eff34f2346b2780290be6d7ed47 We're going to change this function, but first we are going to make its behaviour identical to Sink::poll_ready. This avoids open-coding the call to poll_read on cell_tx. The error handling is still strange. We'll fix that in a moment.